Skip to content

Gql cache resilience - #2651

Open
shangyian wants to merge 3 commits into
DataJunction:mainfrom
shangyian:gql-cache-resilience
Open

shangyian wants to merge 3 commits into
DataJunction:mainfrom
shangyian:gql-cache-resilience

Conversation

@shangyian

Copy link
Copy Markdown
Collaborator

Summary

Test Plan

  • PR has an associated issue: #
  • make check passes
  • make test shows 100% unit test coverage

Deployment Plan

@netlify

netlify Bot commented Oct 25, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for thriving-cassata-78ae72 canceled.

Name Link
🔨 Latest commit 77df943
🔍 Latest deploy log https://app.netlify.com/projects/thriving-cassata-78ae72/deploys/6add95490bd0f3dfb0b214b7

@shangyian
shangyian marked this pull request as ready for review October 25, 2026 05:27
@greptile-apps

greptile-apps Bot commented Oct 25, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge, with the previous finding addressed and no new blocking issues found.

Summary

The PR makes GraphQL response caching opt in by top-level field and falls back to running the query when cache reads or writes fail.

  • GraphQL queries qualify for caching based on their top-level fields.
  • GraphQL requests still run when response-cache calls fail.

Reviews (2) · Last reviewed commit: "Sort and de-duplicate the fields used as..." · Reviewed by Greptile

Comment thread datajunction-server/datajunction_server/api/graphql/main.py Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant