Repository navigation
edits to vignette for style, more visible outputs, fewer agg dfs - #267
Merged
Merged
Conversation
|
📖 pkgdown preview for this PR: https://doi-usgs.github.io/loadflex/preview/pr267/ |
gfkltn
approved these changes
Oct 14, 2026
gfkltn
left a comment
gfkltn
left a comment
There was a problem hiding this comment.
Admin review completed. No issues found.
aappling-usgs
force-pushed
the
vignette-mods
branch
from
October 14, 2026 19:24
6365573 to
089acfb
Compare
5 of 21 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR modifies the vignette. I directly edited vignettes/intro_to_loadflex.Rmd.orig, knitted that to vignettes/intro_to_loadflex.Rmd, committed two figures now produced by that knitting, and added notes in dev/dev.R on how to get those figures created within the vignetes/figure directory where they should be.
This PR should be rebased, updated, and merged after we've merged #264. It miiight be affected by merge of #263 and #266, too, and could certainly be rebased onto those - but I'm trying to keep these four PRs mostly independent, file-wise, and I think #264 is the only one that really affects success in building vignettes/intro_to_loadflex.Rmd.orig. At creation of this PR, the current vignettes/intro_to_loadflex.Rmd is built on the changes in #264, even though I kept those R code changes separate from this PR.