Conversation
* Update World.cpp - Fix getAdventurer in arena * Update createitem.cpp - Simplify adventurer check * Update dwarfmode.lua - Fix adventure arena look cursor * Update Lua API.rst - Improve isAdventureMode doc * Update changelog.txt
* Update Lua API.rst * Update dwarfmode.lua
Bumber64
marked this pull request as ready for review
October 5, 2026 18:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make
getAdventurerapply to adventure arena by checking for adventuregamemodeinstead ofisAdventureMode. Also makedwarfmode.luarespect the adventure look cursor for arena.Tidied up an unnecessary check in
createitem.ccp.Units::getProfessionNamemisbehavior is fixed as a result of thegetAdventurechange. No visible change toWorld::GetCurrentSiteIdbecause arena mode always contains 0 sites.Update docs to clarify that
isAdventureModedoesn't cover arena mode.reveal.cppremains unavailable in arena mode, as swapping back to dwarf arena doesn't triggerSC_WORLD_UNLOADEDto reset state.