Repository navigation
fix: keep details of SpdxLicense with unknown id - #1540
Open
rajanpanth wants to merge 2 commits into
Open
rajanpanth wants to merge 2 commits into
rajanpanth wants to merge 2 commits into
Conversation
A SpdxLicense whose id is not a known SPDX id is normalized as a named license. Pass its acknowledgement, text and properties on, not only its URL. Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: rajanpanth <rajan.pantha@samriddhicollege.edu.np>
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Signed-off-by: rajanpanth <rajan.pantha@samriddhicollege.edu.np>
Documentation build overview
|
|
The fallback in
Disclosure: Review and test verification conducted with assistance from Google Antigravity (Gemini 4 Carbon). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A
SpdxLicensewhose id is not a known SPDX id is normalized as a named license. That fallback only passedurlon, so the licensetext,acknowledgementandpropertieswere lost in JSON and XML. It now passes all four, and the result is the same as for aNamedLicensewith the same data. The per-spec handling ofacknowledgementandpropertiesis unchanged, since the value still goes through the named-license normalizer.One test added to each of
Serialize.JsonNormalize.test.jsandSerialize.XmlNormalize.test.js; both fail without the fix. No snapshot changes. All 4227 tests pass;tsc --noEmitand ESLint are clean.Resolves or fixes issue: #1539
AI Tool Disclosure
Claude CodeClaude Fable 5Look for cases where the library's output loses data or breaks the bundled schemas, reproduce each with a script, then fix this one with a test in each normalizer test file.Affirmation