Repository navigation
fix: XML vulnerability published and updated dates - #1538
Merged
jkowalleck merged 2 commits intoNov 11, 2026
Merged
jkowalleck merged 2 commits into
jkowalleck merged 2 commits into
Conversation
The XML normalizer built `published` and `updated` from the vulnerability's `created` date. Use the matching fields, as the JSON normalizer does, and regenerate the affected snapshots. Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: rajanpanth <rajan.pantha@samriddhicollege.edu.np>
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: rajanpanth <rajan.pantha@samriddhicollege.edu.np>
Documentation build overview
|
jkowalleck
approved these changes
Nov 11, 2026
Member
|
thank you for the report and the fix, @rajanpanth |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The XML normalizer wrote a vulnerability's
createddate into<published>and<updated>as well, because all three elements were built fromdata.created. Each element now uses its own field, as the JSON normalizer already does.Eight snapshot files change (
xml_sortedLists_spec1.{4,5,6,7}.jsonandxml_complex_spec1.{4,5,6,7}.xml.bin). Onlypublishedandupdatedvalues differ, and the new values are the ones the fixture intests/_data/models.jssets. With the fix and the old snapshots those 8 tests fail; with the regenerated ones all 4225 tests pass.tsc --noEmitand ESLint are clean.Resolves or fixes issue: #1537
AI Tool Disclosure
Claude CodeClaude Fable 5Look for cases where the library's XML and JSON output disagree or break the bundled schemas, reproduce each with a script, then fix this one and regenerate the affected snapshots.Affirmation