Repository navigation
ci: build the image on every push, push it only for main, tags and pr… - #260
Open
sandragjacinto wants to merge 1 commit into
Open
sandragjacinto wants to merge 1 commit into
sandragjacinto wants to merge 1 commit into
Conversation
…eview PRs A broken Dockerfile used to show up only after the merge, since #258 builds the image only for deploy targets. build-docker now runs on every push (not Dependabot's, which gets no secrets), with push set from deploy-target: main, tags, preview-labelled PRs and manual runs push the image and get a deploy tag; any other branch only builds it, reading the registry cache without writing it. Needs the push input of CyberCRI/github-workflows build-push.yaml.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…eview PRs
A broken Dockerfile used to show up only after the merge, since #258 builds the image only for deploy targets. build-docker now runs on every push (not Dependabot's, which gets no secrets), with push set from deploy-target: main, tags, preview-labelled PRs and manual runs push the image and get a deploy tag; any other branch only builds it, reading the registry cache without writing it.
Needs the push input of CyberCRI/github-workflows build-push.yaml.
Description
Why?
How?
Screenshots (if appropriate):
Types of changes
Checklist: