You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Yeah you're totally right, there's a logic bug in the VisitClassDeclaration method where it returns early and never gets to the actual validation loop.
the problem is on lines 321 and 334 - if there's no attributes or if the NodeCategory attribute is missing arguments, it just bails out completely. but the validation that checks if the class inherits from a valid node type happens way down at line 347 in that foreach loop, so it never gets reached.
the core issue is just moving that foreach validation loop outside of the conditional blocks so it always executes,
Activity
Xlinka commentedon Sep 23, 2025
Yeah you're totally right, there's a logic bug in the VisitClassDeclaration method where it returns early and never gets to the actual validation loop.
the problem is on lines 321 and 334 - if there's no attributes or if the NodeCategory attribute is missing arguments, it just bails out completely. but the validation that checks if the class inherits from a valid node type happens way down at line 347 in that foreach loop, so it never gets reached.
the core issue is just moving that foreach validation loop outside of the conditional blocks so it always executes,
I can fix this later on if you want me to @Nytra
Nytra commentedon Sep 23, 2025
sure
Xlinka commentedon Sep 30, 2025
#5