Repository navigation
馃悰 Fix flaky Listener_StopThenStart_KeepsServing - #10
Merged
Merged
Conversation
Seeing the Stop between the two, it returned from GetContext and closed the listener, and Start threw ObjectDisposedException.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI failed on main (run 37754496626) with
ObjectDisposedExceptionfromHttpListener.Start()inListener_StopThenStart_KeepsServing. The same code had passed on the PR run.The test server's serving thread polls
GetContext()every 50 ms. If it wakes between the test'sStop()andStart(), it sees the stop, returnsnull, andServecloses the listener, soStart()correctly throws.TestServer.Restart()now sets a flag around the pair, andServewaits for it to clear instead of exiting. Test-only change;HttpListeneris unchanged.