Record: the decision record matches the pipeline after #897 - #930
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
comments/astra only, fine to merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings
astra.yamlin line with what the committed pipeline does since #897. Found by a sentence-by-sentence audit of every decision against the code: one cheap reader per decision, then one reviewer per sub-analysis holding the bar "would a reader otherwise believe something false about the catalogue?".default_tile.sex/config_tile_Sx.inisettings are scoped to the SExtractor (image-sims) path; on data, FLAGS and MAG_AUTO are DR6's. The.sexselectors (DOT_SEX_FILE) are now pinned in Values, so a runner pointed at another file fails the check.detection_threshold_policynow cites the Check that sim-side tile SExtractor reproduces the DR6 detections data uses #929 measurement: on the DR6 image of 186.307 this config reproduces DR6 detection (99.89% complete, 100% pure).merge_final_cat.pydocstring on never-fit rows (it had the flag semantics backwards since Metacal flags are nonzero whenever a type has no measured shear, using ngmix's own bits #854), the TILE_ID comment, and the README mccd lines. No behaviour change.Unit and module tests in the dev container: 801 passed, 1 skipped.
astra-tools validatepasses. Pixel-scale andstar_selection_boxedits ride #927;object_position_columnsrides the windowed-positions PR.Claude Opus 5.5 on behalf of Cail
🤖 Generated with Claude Code