Skip to content

MCCD exposure chain cannot run as committed: reads the deleted mask_runner, skips mask_query, wrong merge section, missing PSF key #917

Description

@cailmdaley

Marked [LINT] in the decision record (#875). workflow/config/cfis/config_exp_mccd.ini was not updated when eb93838 deleted in-house mask generation: SExtractor still reads pipeline_flag from mask_runner, and [SETOOLS_RUNNER] reads SExtractor directly so the chain skips mask_query and can never carry MASK_EXT. While fixing it, two older defects surfaced: [MCCD_MERGE_STARCAT_RUNNER] is not the section merge_starcat_runner reads (MERGE_STARCAT_RUNNER), and [MCCD_PLOTS_RUNNER] lacks the PSF key the plots runner requires; RUN_DATETIME is not set to False so the hardcoded run-dir paths cannot resolve; completeness.py's MCCD table omits mask_query_runner and expects 80 preprocessing outputs where the runner writes 2. The committed workflow selects PSFEx, so nothing running today is affected. Two static config tests (every *_runner reference names an existing runner; every unconditional config read has its key) would have caught all of it.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions