Repository navigation
fix: detect non-Python nodes in concore status and stop - #616
Open
bhuvan-somisetty wants to merge 2 commits into
Open
bhuvan-somisetty wants to merge 2 commits into
bhuvan-somisetty wants to merge 2 commits into
Conversation
Only concore.py / concoredocker.py counted as runtime markers, so C++, Java, Verilog and MATLAB node folders never matched and stop left them running. Accept the runtime file mkconcore copies for each language.
avinxshKD
reviewed
Oct 15, 2026
| ["concore.hpp", "concore.java", "concore.v", "concore_read.m"], | ||
| ) | ||
| def test_true_for_non_python_nodes(self, tmp_path, runtime_file): | ||
| # C++, Java, Verilog and MATLAB nodes never get concore.py (#615) |
Contributor
There was a problem hiding this comment.
Avoid adding issue or PR number inside code comments.
Author
There was a problem hiding this comment.
Ah right, my bad. Took it out, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #615
A node folder now counts if it has
concore.iportplus the runtime file mkconcore copies for its language (concore.hpp,concore.java,concore.v,concore_*.m, or the docker versions), not justconcore.py. Soconcore statuslists C++, Java, Verilog and MATLAB nodes andconcore stopactually kills them.Added tests for each language. They fail on dev and pass with this change. Full suite passes.