Repository navigation
fix: write a single ec-code or smiles annotation as a list - #183
Merged
Merged
Conversation
…st, as RAVEN does
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
write_yaml_modelwrites a singleec-codeorsmilesannotation as a list, as RAVEN'swriteYAMLmodeldoes. cobra keeps one identifier as a bare string, so a model with one EC code per reaction was written as a scalar, where RAVEN writes a list. The other annotation keys keep their collapsed form.Not checked: other annotation keys that RAVEN always writes as lists.
Companion changes: CompMetEng/geckopy#70 and CompMetEng/GECKO#13.