Repository navigation
get_conc_control_coeffs takes the finite-difference coefficients by default - #76
Merged
Merged
Conversation
…efault, as getConcControlCoeffs does method="shadow_price" keeps the reduced-cost path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get_conc_control_coeffsraises one usage bound byfold_change(2), re-solves and divides the rise of the optimum by the rise of the bound, as GECKO'sgetConcControlCoeffsdoes.method="shadow_price"reads the reduced cost of the usage reactions instead, which is unreliable at a degenerate vertex. The finite-difference path needs one solve per protein, so each iteration offlexibilize_enz_concs, which calls it, takes minutes on a genome-scale ecModel.Parity: CompMetEng/raven-gecko-parity#117.