Repository navigation
Return the infeasible solution from every solve instead of raising - #75
Merged
Merged
Conversation
… from the solver status after slim_optimize
…imit-protein, kcat-tuning and analysis solves use it
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
model.optimize()fails on an infeasible LP instead of returning an infeasible solution: Gurobi with presolve raisesGurobiError: Unable to retrieve attribute 'X', and the optlang scipy interface returnsNoneprimals so cobra raisesTypeError. This made a test under pytest-xdist fail intermittently.geckopy.solver_support.optimize_model(model, **kwargs)returns the solution as usual, and for a non-optimal solver status returns aSolutionwith that status, a NaN objective and NaN fluxes. With an optimal status every error is raised.flexibilize_enz_concs,get_conc_control_coeffs,relax_enz_concs,sensitivity_tuning,sigma_fitter,evotunesimulate,bottlenecks,ec_fseof,ec_fva) use it.flexibilize_enz_concsandsensitivity_tuningis checked withslim_optimize(error_value=nan)and the solver status.Presolve=2, the feasible case and error pass-through. CHANGELOG entry added.