Repository navigation
KEGG database, solver tolerance and zero-total f factor as in GECKO - #74
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make_ec_modelreadsdata/kegg.tsvof the adapter folder when nokegg_dbis passed and the file exists, asmakeEcModeldoes. It does not download the file.load_conventional_gemsets the solver tolerance of the model to RAVEN's 1e-9 (raven_toolbox.utils.solver.set_raven_tolerance); models read withload_ec_modelget it from the raven-toolbox reader. This needs the raven-toolbox change in CompMetEng/raven-toolbox that addsutils.solver, so this PR passes its tests once that is merged.calculate_f_factorreturns NaN with a warning when the total proteome abundance is zero, ascalculateFfactordoes.