Repository navigation
Keep version.txt and the README version off develop - #26
Merged
Merged
Conversation
version.txt and the version sentence of the README exist on main only. convertCustomKcats reads the version through a local function that returns 'unknown' when version.txt is absent, as saveEcModel does. A check rejects version.txt on develop, and CONTRIBUTING describes the release branch and the sync back into develop.
Unit test results73 tests 73 ✅ 16s ⏱️ Results for commit ad4ce04. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
version.txtand the version sentence of the README exist onmainonly.developis ahead of the last release by an unknown number of changes and is not at a version.version.txtis removed.convertCustomKcatsreads the version through a local function that returnsunknownwhen the file is missing, assaveEcModelandupgradeGECKOprojectdo..github/workflows/branch-hygiene.ymlfails a pull request or push todevelopwhenversion.txtis tracked..github/CONTRIBUTING.mddescribes the release: a branchrelease/<version>fromdevelopthat addsversion.txtand the README sentence, a pull request intomainmerged with a merge commit, the tag, and a pull request that mergesmainback intodevelopwithout the release-only changes.