Repository navigation
fix: read EC numbers joined by a semicolon without a space as separate codes - #14
Merged
Merged
Conversation
A database cell that joins codes with ';' and no space, such as '1.1.1.1;2.2.2.2', gave the single string 'EC1.1.1.12.2.2.2'. The cell is now split on white space and semicolons, as geckopy does.
Unit test results63 tests 63 ✅ 11s ⏱️ Results for commit abb658b. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getECstringsplits the EC numbers of a database cell on white space and on semicolons. A cell that joins codes with;and no space, such as1.1.1.1;2.2.2.2, gave the single stringEC1.1.1.12.2.2.2, andfindECInDBreturned1.1.1.12.2.2.2. It now returns1.1.1.1;2.2.2.2, which is what geckopy gives for the same cell. UniProt and KEGG separate codes with a space, so their cells are read as before.The unit test
tc0246covers cells separated by a space, by;, by;alone and by repeated or surrounding separators.Companion change: CompMetEng/raven-gecko-parity#141 adds the
ec_lookup_edge_casesvariant that compares both sides on such a cell.