Repository navigation
docs: localize the English step and range connectors in published locales - #210
Merged
Merged
Conversation
…ales Published locales (zh, zh-TW, ja, ko, es) still had English words inside Range cells of older pages: - "(step: 0.01)" / "(step of 8)" / ", step 16" kept the English word step - "0 to 100" / "-MAX_RESOLUTION to MAX_RESOLUTION" kept the English connector - "min 0.0, max 1.0, step 0.01" stayed fully English Each cell is rewritten with the wording already used by the same locale's localized cells (步长 / 步進值 / ステップ / 단계 / paso), so no new translation judgement was made. Only the Range column changes: 672 cells in 111 files, added == deleted on every file, table row counts unchanged.
|
Warning Review limit reached
This review includes 111 billable files and costs up to $27.75. View limit details
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Published locales still had English words inside the
Rangecolumn of older pages. This PR rewrites only those cells, using the wording the same locale already uses elsewhere, so no new translation judgement is involved.(step: 0.01)/(step 0.01)/(step of 8)/, step 16→ localized step word0 to 100/-MAX_RESOLUTION to MAX_RESOLUTION→ localized connectormin 0.0, max 1.0, step 0.01→ localizedmin/max/stepprose formWording taken from corpus precedent (counts on
origin/main):0.0 - 1.0 （步长：0.01）(78 pages), zh-TW（步進值：0.01）(79), ja（ステップ 0.01）(79), ko(단계: 0.01)(79), es(paso: 0.01)(85)Scope
zh,zh-TW,ja,ko,es(the locales the docs site publishes)en.mduntouched (0 files), no prose, no titles, no Data Type / Required columnsen.mdfor all 111 filesVerification
fix_translation_preamble.py --check-only --changed-only: 0 leaked linescheck_doc_structure.py --changed-only: 0 defectscheck_md_format.py --changed-only: 111 files, 0 errors, 0 warningsN to Min published-locale Range cells: 0; residual(stepin data rows: only English prose cells left on purpose (see below)Left for a separate pass
Multiline text,Single image,Any text,0.0 to unlimited (step 1e-6),0 to 2147483647 (default: 42), …), mostly zh 99 / zh-TW 110 / ja 85 / ko 170. They need per-phrase wording, not a mechanical swap.fr,ru,ar,tr,pt-BR,fa,de,he,it) have the same residue at a larger scale: 2,249 mechanicalstep/tocells plus 340 English-prose cells across ~240 pages (he 595, it 328, de 262, ar 223, tr 206, fa 199, ru 179, fr 137, pt-BR 120). They are not user-visible today and are a separate batch.After merge
The Comfy-Org/docs sync follows from
origin/mainin the next sync batch; this PR does not touch the docs repo.