Repository navigation
chore: enforce the structure checks for es, now a published locale - #208
Merged
comfyui-wiki merged 1 commit intoOct 26, 2026
Merged
Conversation
The docs site publishes Spanish (docs#2107 added the built-in node reference, docs#2112 completed the locale), but the structure checker still treated es as translated-but-not-rendered, so Spanish defects were never enforcement-level. The existing es corpus is already clean (full-tree scan: 0 defects with es enforced), so turning it on does not require doc changes. Also updates the stale 'EN, zh, ja, ko' comments in sync_to_comfy_docs.py to the five-locale tuple it actually builds.
|
No actionable comments were generated in the recent review.
 |
| Layer / File(s) | Summary |
|---|---|
Enforcement and locale documentation .github/scripts/check_doc_structure.py, docs-generation/scripts/sync_to_comfy_docs.py |
The checker includes Spanish in its enforced locales. The sync script’s category-map comment and parameter documentation list Spanish. The sync script’s executable behavior is unchanged. |
Suggested reviewers: comfyui-wiki
Priority:
Merge Risk: 
3aa81
-
No actionable merge-blocking risk remains.
Pre-merge checks: 
-
Check name Status Explanation Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request.
Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Create a new PR
✨ Simplify code
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
esis now a locale the docs site actually publishes (docs#2107added the Spanish built-in node reference,docs#2112completed the Spanish site), butcheck_doc_structure.pystill treated it as translated-but-not-rendered:So a Spanish page with a broken heading level, a missing section or a wrong "Edit on GitHub" link is repaired silently in
--fixmode and never counted as a violation, while the same defect in ja/zh/ko fails the check.Change
.github/scripts/check_doc_structure.py—ENFORCED_LANGS = ("ja", "zh", "ko", "es"), comment updated.docs-generation/scripts/sync_to_comfy_docs.py— comment-only: the group-label tuple is already(EN, zh, ja, ko, es), the two comments still said four locales.Nothing else needed: the sync side already publishes es (
BUILTIN_ES,"page_prefix": "es/built-in-nodes",lang_idx: 4,DEFAULT_GROUP_ES, and all 28CATEGORY_TO_GROUPentries carry the Spanish label).Verification
python3 .github/scripts/check_doc_structure.py(full tree, es enforced)0 repaired, 0 defect(s) found— the existing es corpus already conforms--changed-only --base origin/main0 repaired, 0 defect(s) foundpython3 .github/scripts/check_md_format.py(full tree)0 errors, 125 warnings— unchangedEnabling the rules therefore does not require any doc change today; it only means Spanish defects become enforcement-level from now on.