Skip to content

docs: document the required Provider field when saving Comfy Cloud API keys - #1791

Closed
lin-bot23 wants to merge 1 commit into
Comfy-Org:mainfrom
lin-bot23:cloud-import-secrets-provider
Closed

lin-bot23 wants to merge 1 commit into
Comfy-Org:mainfrom
lin-bot23:cloud-import-secrets-provider

Conversation

@lin-bot23

Copy link
Copy Markdown
Contributor

@lin-bot23

Small accuracy fix on the Comfy Cloud private model import page.

What changed

cloud/import-models.mdx (EN/zh/ja/ko), section Save your API keys:

  • Step 2 now describes the actual dialog: click Add Secret, choose the Provider the key belongs to (such as Hugging Face or Civitai), give the key a name, and paste the key into Secret Value.
  • New note: secrets are encrypted and cannot be viewed again after saving (keep a copy), you can save one key per provider, and a key is replaced by opening it and entering a new value.
  • ko: fixed the mistranslation of the Secrets section (비밀번호, "password" -> 시크릿(Secrets)), including the screenshot alt text.

Why

The page previously said only "Click to add your API keys (you can name the key anything you like)". The Provider field is required: submitting without it fails with "Provider is required", and the provider is what enables automatic token usage when importing from that platform. One key per provider is enforced by the dialog (providers already configured are disabled in the select) and by the API (DUPLICATE_PROVIDER).

Verification

  • Frontend source on origin/main: src/platform/secrets/composables/useSecretForm.ts (validate() rejects an empty provider via secrets.errors.providerRequired, disables providers already saved, secretValueHint = encrypted and cannot be viewed again, edit mode replaces the value) and src/platform/secrets/components/SecretFormDialog.vue.
  • pnpm translate:sync-hash -- cloud/import-models.mdx: only translationSourceHash plus the changed block hash were refreshed in zh/ja/ko.
  • Diff is limited to the four language files of this page, no em dashes, <Note> tags balanced.

@coderabbitai

coderabbitai Bot commented Sep 26, 2026

Copy link
Copy Markdown

Warning

Review paused — included plan limit reached

Keep your review moving with free on-demand reviews.

  • Run this review for free

On-demand reviews are free for the next 14 days.

Promotion and pricing details

On-demand reviews are free for the next 14 days. After that, they cost $0.25 per reviewed file.

Review limit details

Or wait 14 minutes for your next included review.

Check out review usage here.

Limit details: You’ve used all 2 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 09a17c4b-630d-48f1-a279-7d36e386c5a6

📥 Commits

Reviewing files that changed from the base of the PR and between 2424a48 and 1ad0fd4.

📒 Files selected for processing (4)
  • cloud/import-models.mdx
  • ja/cloud/import-models.mdx
  • ko/cloud/import-models.mdx
  • zh/cloud/import-models.mdx

Comment @coderabbitai help to get the list of available commands.

@comfyui-wiki

Copy link
Copy Markdown
Member

Checked against ComfyUI_frontend src/platform/secrets/ (provider list, required provider, one secret per provider, value not viewable after save). The new step and note are accurate. LGTM.

@lin-bot23

Copy link
Copy Markdown
Contributor Author

Superseded. The Provider field fix for cloud/import-models.mdx now lives in #1796, together with the API Keys & Secrets panel page it points to, so both changes land in one place and the es locale is covered too. Closing this branch to avoid two PRs over the same topic.

@lin-bot23 lin-bot23 closed this Oct 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants