Repository navigation
Preserve closed configdrift updates for safe reconciliation - #49
Merged
Coding-Dev-Tools merged 9 commits intoOct 19, 2026
Merged
Conversation
…nt-green guard) - exit 1 if zero config files loaded across all environment dirs - exit 1 if baseline env loaded no keys (empty-baseline diff would flag everything) - +5 regression tests in TestScanEmptyGuards; suite 148 passed, ruff clean
…ype drift Python's == treats True == 1, so a config change like 'debug: true -> debug: 1' silently compared as no drift. _values_differ() now flags cross-type changes (bool vs number) while same-type comparisons are unchanged. +7 regression tests in TestTypeSensitiveComparison; suite 155 passed, ruff clean.
scan merges all config files in an environment directory via dict.update(), so two files defining the same flattened key with different values silently resolved to glob-order winner. Now emits a stderr warning naming both files (stderr so --output json stdout stays machine-readable) and globs files in sorted order for deterministic winner selection. +3 tests (158 pass, ruff clean).
Validated local candidate: b9eb216fd904d773370b6fa16544d2f9148d6804 - b9eb216fd904d773370b6fa16544d2f9148d6804 fix(scan): reject incomplete environments and preserve JSON diagnostics
Coding-Dev-Tools
marked this pull request as ready for review
October 17, 2026 13:12
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Automated Code ReviewRuff lint: 0 issue(s)Ruff format: CleanSecret detection: 0 potential secret(s)Verdict: PASS Automated by Coding-Dev-Tools/.github reusable workflow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Originally opened as a draft preservation snapshot of PR #46's exact head
724ad434bbd331e68ee9e864b634cddb56199ec8, made visible as a new review branch because PR #46 is closed. The owner closed #46 with the note: “superseded by main and would revert atomic write features.” The original instruction was to compare that snapshot's silent-green scan guard, type-sensitive diff, and duplicate-key warning againstmain, then carry forward only safe hunks without merging the snapshot unchanged. No tests were run in that original preservation pass.PR #49 was merged on 2026-10-19 04:42:10 UTC with head
c9d4755559a02f41e452ba3c48b73e7033052549(treea79093210b4c888b761b89d1fb2d028c41600317) and merge commit2d7ed937b836572c5bfa8bb0393755eae077d7b5. The read-only capture on 2026-10-19 at 09:13 UTC recordedmainat2d7ed937b836572c5bfa8bb0393755eae077d7b5, with 5 successful checks on the PR head and 7 successful checks on that primary commit. The original preservation-pass statement above remains historical. Runtime and deployment acceptance remain separate release gates.