Manchester | 26-ITP-Sep | Monsur Abdulrahman | Sprint 2 | Coursework/sprint 2 by Monsur0001 · Pull Request #1600 · CodeYourFuture/Module-JavaScript-Fundamentals

Monsur0001 · 2026-09-26T11:11:31Z

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Task code

CYF-1039

Changelist

I made corrections to some errors in the code provided and also made some explanations on the code provided.

…initials.js

…aths.js

…eration process

… extraction works correctly

…ention

… comments for clarity

…larity on variable usage and limitations

netlify · 2026-09-26T11:11:37Z

✅ Deploy Preview for cyf-onboarding-module ready!

Name	Link
🔨 Latest commit	`b381b0d`
🔍 Latest deploy log	https://app.netlify.com/projects/cyf-onboarding-module/deploys/6ab7e4c42cfb2c000816f95b
😎 Deploy Preview	https://deploy-preview-1600--cyf-onboarding-module.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	2 paths audited Performance: 100 (no change from production) Accessibility: 100 (no change from production) Best Practices: 100 (no change from production) SEO: 86 (no change from production) PWA: - View the detailed breakdown and full score reports
🤖 Make changes	Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

cjyuan · 2026-09-26T11:15:55Z

+Math.random() //generates a random decimal number between 0  and 1. This means that the value of Math.random() 
+// can be any number between 0 and 1, but it will never be exactly 1.


Note: We could also use the concise and precise interval notation to describe a range of values.

[, ] => inclusion

(, ) => exclusion

For example, $x$ is a number in $[1, 10)$ means:

$x$ is a number between 1 and 10, including 1 but excluding 10.

Thank you for your feedback, I have corrected the explanation to reflect the inclusion and exclusion terms

cjyuan · 2026-09-26T11:17:00Z

-const cardNumber = 4533787178994213;
+const cardNumber = "4533787178994213";
 const last4Digits = cardNumber.slice(-4);


Suppose you were not allowed to modify the statement const cardNumber = 4533787178994213;
(that is, keep the variable's value unchanged).
How would you modify the code (through type conversion) to still being able to use .slice(-4) to extract the last 4 digits from the given number.

I could also do same by converting card number to string using cardNumber.toString().slice(-4).

I had used the (“”) to convert the digits to String in this code

cjyuan · 2026-09-26T11:17:43Z

+const TwelveHourClockTime = "8:53pm";
+const TwentyFourHourClockTime = "20:53";


In JS naming convention, variable names usually begins with a lowercase letter. Names starting with an uppercase letter are used for built-in or custom data types (e.g., Math)

Thank you for pointing that out. I never knew I made such mistake 😀. I have made the correction to reflect the camelCasing convention.

cjyuan · 2026-09-26T11:18:29Z

+The error is occurring on line 5 because the "," character was ommited in the replaceAll function, to fix the problem,
+ we need to include the "," character in the replaceAll function like this: priceAfterOneYear.replaceAll(",", "")


We could more precisely describe "A comma is missing between "," and "" in the function call" as:
A comma is missing between the ___________s.

What is this programming term that refers to the values passed to a function? It begins with an 'a'.

Thank you so much for this, I have made a correction to that effect, also I now know the difference between argument and a parameter. While they are used interchangeably, an argument is the exact value we passed to the function while parameter is the placeholder value

cjyuan · 2026-09-26T11:21:02Z


 // e) What do you think the variable result represents? Can you think of a better name for this variable?
+// The variable result represents the formatted time string in the format "hours:minutes:seconds".
+// A better name for this variable could be "formattedTime" or "movieDuration" 


Note: formattedTime could more clearly indicate the variable stores a formatted string.

Thank you for letting me Know this

…and exclusion concepts

…ention

…ion call.

…nts for clarity and consistency in percentage change calculations

cjyuan · 2026-09-26T21:55:20Z

Changes so far look good.

Could you also address this comment? #1600 (comment)

Monsur0001 added 14 commits September 19, 2026 01:20

Clarify the assignment operation in count.js

1b5ce16

Implement initials extraction from first, middle, and last names

6f2377a

Extracts first characters from firstname, middlename and lastname in …

78f922e

…initials.js

Implement extraction of directory and extension from file path in 3-p…

1ca86a4

…aths.js

Fix typo in explanation of assignment operation in count.js

6fd351c

Enhance documentation in 4-random.js to clarify the random number gen…

b117813

…eration process

Add comments to clarify instructions in 0.js for better readability

fa638a8

Change age variable from const to let for reassignment

4c61057

Fix console log placement to ensure cityOfBirth is defined before usage

9de5303

Fix cardNumber definition to use string format and ensure last4Digits…

2c371d5

… extraction works correctly

Fix variable naming for clock time constants to follow camelCase conv…

c52b17e

…ention

Fix typo in replaceAll function call for priceAfterOneYear and update…

2ebfefd

… comments for clarity

Experiment movieLength to a negative value and enhance comments for c…

e16a1ca

…larity on variable usage and limitations

Step-by-step breakdown of the price conversion process

c9aaa7a

Monsur0001 added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. 📅 Sprint 2 Assigned during Sprint 2 of this module labels Sep 26, 2026

cjyuan added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Sep 26, 2026

cjyuan reviewed Sep 26, 2026

View reviewed changes

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Sep 26, 2026

Monsur0001 added 5 commits September 26, 2026 15:57

Specify that Math.random() includes 0 but not 1, using the inclusion …

ab1e16c

…and exclusion concepts

Fix variable naming for clock time constants to follow camelCase conv…

1421faf

…ention

Clarify error explanation regarding missing comma in replaceAll funct…

209b644

…ion call.

Clarify explanation to reflect the word "Argument" and Refactor comme…

623bd7d

…nts for clarity and consistency in percentage change calculations

Refactor variable name suggestion for clarity in time formatting

b381b0d

Monsur0001 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 26, 2026

cjyuan removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 26, 2026

Navigation Menu

Uh oh!

Manchester | 26-ITP-Sep | Monsur Abdulrahman | Sprint 2 | Coursework/sprint 2 - #1600

Manchester | 26-ITP-Sep | Monsur Abdulrahman | Sprint 2 | Coursework/sprint 2#1600
Monsur0001 wants to merge 19 commits into
CodeYourFuture:mainfrom
Monsur0001:coursework/sprint-2

Monsur0001 commented Sep 26, 2026

Uh oh!

netlify Bot commented Sep 26, 2026 •

edited

Loading

Uh oh!

cjyuan Sep 26, 2026

Uh oh!

Monsur0001 Sep 26, 2026

Uh oh!

cjyuan Sep 26, 2026

Uh oh!

Monsur0001 Sep 27, 2026

Uh oh!

cjyuan Sep 26, 2026

Uh oh!

Monsur0001 Sep 26, 2026

Uh oh!

cjyuan Sep 26, 2026

Uh oh!

Monsur0001 Sep 26, 2026

Uh oh!

cjyuan Sep 26, 2026

Uh oh!

Monsur0001 Sep 26, 2026

Uh oh!

cjyuan commented Sep 26, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		Math.random() //generates a random decimal number between 0 and 1. This means that the value of Math.random()
		// can be any number between 0 and 1, but it will never be exactly 1.

		const TwelveHourClockTime = "8:53pm";
		const TwentyFourHourClockTime = "20:53"; No newline at end of file

		The error is occurring on line 5 because the "," character was ommited in the replaceAll function, to fix the problem,
		we need to include the "," character in the replaceAll function like this: priceAfterOneYear.replaceAll(",", "")

Uh oh!

Conversation

Monsur0001 commented Sep 26, 2026

Task code

Changelist

Uh oh!

netlify Bot commented Sep 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for cyf-onboarding-module ready!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cjyuan commented Sep 26, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

netlify Bot commented Sep 26, 2026 •

edited

Loading