London | 26-ITP-SEP | Shirin Panahian | sprint 3 | sprint 3 Acoursework - #1596
Open
shirinpanahian wants to merge 11 commits into
Open
shirinpanahian wants to merge 11 commits into
shirinpanahian wants to merge 11 commits into
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
shirinpanahian
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
This comment has been minimized.
This comment has been minimized.
shirinpanahian
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
shirinpanahian
force-pushed
the
acoursework/sprint-3
branch
from
September 25, 2026 21:57
af56932 to
31e4589
Compare
shirinpanahian
added
Needs Review
abdishakoor-dev
left a comment
abdishakoor-dev
left a comment
Contributor
There was a problem hiding this comment.
Your prediction in 1-key-errors/1.js finds both problems: the repeated name and the scope. Prettier passes on every file too.
Four things before I can mark this Complete:
2-cases.js: see my comment on line 18.3-to-pounds.js: see my comment on line 7.2-mandatory-debug/2.js: see my comment on line 28.- The PR title says
25-ITP-SEP. Your cohort is26-ITP-Sep. Please edit the title.
Add the Needs Review label again once you've pushed.
| // Use the MDN string documentation to help you find a solution | ||
| // This might help https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/toUpperCase | ||
| function toUpperSnakeCase(text) { | ||
| const newText = text.replace(" ", "_"); |
Contributor
There was a problem hiding this comment.
Try toUpperSnakeCase("lord of the rings"). What does it return? The exercise expects "LORD_OF_THE_RINGS". How many spaces does replace change? The MDN page for replace will help.
| // You will need to declare a function called toPounds with an appropriately named parameter. | ||
|
|
||
| // You should call this function a number of times to check it works for different inputs | ||
| function toPound(penceString) { |
Contributor
There was a problem hiding this comment.
Line 4 asks for a function called toPounds. What is your function called?
Author
There was a problem hiding this comment.
yes, my function name was toPound, It should be toPounds.
|
|
||
| // Finally, correct the code to fix the problem | ||
| // =============> write your new code here | ||
| let num = 103; |
Contributor
There was a problem hiding this comment.
Is num on line 28 used now? Your function uses its own num parameter. If line 28 is not needed, remove it.
abdishakoor-dev
added
Reviewed
shirinpanahian
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Task code
CYF-1053
Changelist
I complete course work sprint 3