London | 26-ITP-Sep | Abakar Souleyman | Sprint 3 | Coursework by abmhts · Pull Request #1583 · CodeYourFuture/Module-JavaScript-Fundamentals

abmhts · 2026-09-24T10:24:07Z

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Task code

CYF-1053

Changelist

Completed Sprint 3 tasks including time formatting, BMI calculation, toPounds, getLastDigit, and square functions.
Also fixed return statements, naming conventions, and documented the errors, predictions, and solutions.

netlify · 2026-09-24T10:24:13Z

✅ Deploy Preview for cyf-onboarding-module ready!

Name	Link
🔨 Latest commit	`89504ac`
🔍 Latest deploy log	https://app.netlify.com/projects/cyf-onboarding-module/deploys/6aba71b593c2a200089c5c8c
😎 Deploy Preview	https://deploy-preview-1583--cyf-onboarding-module.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	2 paths audited Performance: 100 (no change from production) Accessibility: 100 (no change from production) Best Practices: 100 (no change from production) SEO: 86 (no change from production) PWA: - View the detailed breakdown and full score reports
🤖 Make changes	Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

This reverts commit add8d2e.

hey-hammad

Nice effort, one minor issues needs fixing. Thanks

hey-hammad · 2026-09-26T11:37:30Z

 // Finally, correct the code to fix the problem
 // =============> write your new code here
+
+function convertToPercentage() {


this fixes the issue, however the does the function still works correctly?

Think about, when given an input can the does the function return the correct output?

The function wasn’t producing the correct output, but I’ve corrected it now. Thank you

abdishakoor-dev

convertToPercentage works now for any input, thanks. Your time-format answers are all correct too.

A few things before I can mark this Complete:

1-key-errors/0.js: line 14 does not match your new code.
1-key-errors/1.js line 23 and 2-mandatory-debug/2.js line 34: see my comments there.
1-key-errors/2.js: line 14 is still empty.
2-cases.js: see my comment on the function name.
Formatting. "My code is consistently formatted" is on the checklist. The tool that does it is called Prettier. It fixes spacing and indentation to one agreed style. Then a reviewer only sees the changes you meant to make. At the moment all 10 of your files fail that check.

Prettier comes with the CYF extension pack from onboarding. Not sure you have it? In VS Code, go to Extensions and search for CodeYourFuture Extension Pack: https://marketplace.visualstudio.com/items?itemName=CodeYourFuture.cyf-extension-pack

Then open each file you changed. Right click in the editor and choose Format Document. Pick Prettier if VS Code asks. Save and commit. To make this happen every time you save, follow the format on save steps here: https://github.com/CodeYourFuture/Module-JavaScript-Fundamentals/blob/main/practical_guide.md

Add the Needs Review label again once you've pushed.

abdishakoor-dev · 2026-09-28T12:41:46Z

+// }

 // =============> write your explanation here
+  //- I changed the variable name to "strg" to avoid the error.


Your code on line 17 doesn't use strg any more. Does line 14 still describe your fix? Update it to match.

updated the explanation on line 14.

abdishakoor-dev · 2026-09-28T12:41:46Z

+
+// =============> write your new code here
+
+const decimalNumber = 0.5;


Line 27 uses decimalNumber. Which one does it use, line 23 or the parameter on line 25? Is line 23 needed? If not, remove it.

It uses the parameter defined on line 25. Since we’re not using the previously declared value of 0.5, I removed it as it was unnecessary.

abdishakoor-dev · 2026-09-28T12:41:46Z

+  //-The function was looking at the outside "num" but Now there are two (num) one outside the scope "const num= 103" and i added another inside the function scope.
+  //-The function calculates something and returns it then console.log outside receives that returned value and prints it.
+
+  const num = 103;


Is num on line 34 used now? Your function uses its own num parameter. If line 34 is not needed, remove it.

I removed the unnecessary const num = 103 because the function already receives num as a parameter.

abdishakoor-dev · 2026-09-28T12:41:46Z

+//     return num * num;
+// }

 // =============> write the error message here


This answer is still empty. Your prediction on line 8 says SyntaxError. Was that right? Write the error name here.

updated the error message.

abdishakoor-dev · 2026-09-28T12:41:46Z

 // Use the MDN string documentation to help you find a solution
 // This might help https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/toUpperCase
+
+function convertToUpperCase(sentence) {


Function names should tell others what the function does. If you use toUpperCase() as an inspiration, what would be a better name for this function? Remember you have been asked for a function to convert yo upper snake case, not just upper case. There is a difference.

Changed to " toUpperSnakeCase " which I think is more descriptive and closely related to what the function does.

I ran Prettier on Sprint 3 folder.

abmhts added 11 commits September 16, 2026 16:14

Convert price strings to numbers before calculating

3bdfb60

explaining error msg and fix the code

15e3b83

Explaining the error, prediction, and fix

a44bb25

fix function square code error

c5a6226

Added return statement to fix the error

052c090

fix return statement

d6eb93e

BMI calculation code

5afd460

fix of get last digit function error

a379651

convert to UPPER_SNAKE_CASE

e9fda63

added function called toPounds

f0201dd

time-format

c4470d9

abmhts added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 24, 2026

This comment has been minimized.

Sign in to view

github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 24, 2026

This comment has been minimized.

Sign in to view

Delete Sprint-2/3-mandatory-interpret/1-percentage-change.js

add8d2e

abmhts added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 24, 2026

This comment has been minimized.

Sign in to view

github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 24, 2026

abmhts added 2 commits September 24, 2026 12:40

Revert "Delete Sprint-2/3-mandatory-interpret/1-percentage-change.js"

73113c5

This reverts commit add8d2e.

Remove accidentally added file

fc9a860

abmhts added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 24, 2026

This comment has been minimized.

Sign in to view

github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 24, 2026

Restore Sprint-2 file

6501234

abmhts added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 24, 2026

hey-hammad added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Sep 26, 2026

hey-hammad suggested changes Sep 26, 2026

View reviewed changes

hey-hammad added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Sep 26, 2026

Update- explaining the error, prediction, and fix

65e5b19

abmhts added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Sep 26, 2026

abdishakoor-dev added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Sep 28, 2026

update - explaining error msg and fix the code

1b143ad

abdishakoor-dev reviewed Sep 28, 2026

View reviewed changes

abdishakoor-dev added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Sep 28, 2026

abmhts added 6 commits September 28, 2026 13:53

Update 2- explaining error msg and fix the code

2583b44

update 2- Explaining the error, prediction, and fix

b124f10

update

286c2a2

update - fix function square code error

ff0eee9

Update - convert to UPPER_SNAKE_CASE

62e622c

Applied Prettier

89504ac

abmhts added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Sep 28, 2026


		// =============> write your new code here

		const decimalNumber = 0.5;

Uh oh!

Conversation

abmhts commented Sep 24, 2026

Task code

Changelist

Uh oh!

netlify Bot commented Sep 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for cyf-onboarding-module ready!

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

hey-hammad left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

abdishakoor-dev left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

abdishakoor-dev Sep 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

netlify Bot commented Sep 24, 2026 •

edited

Loading

abdishakoor-dev Sep 28, 2026 •

edited

Loading