London | 26-ITP-Sep | Bartosz Kawiak| Sprint 3 | Coursework-completed by bartoszkawiak · Pull Request #1582 · CodeYourFuture/Module-JavaScript-Fundamentals

bartoszkawiak · 2026-09-23T15:39:23Z

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Task code

CYF-1053

Changelist

Completed the Sprint 3 exercises, including working with functions, BMI calculations, time formatting, testing different inputs and fixing bugs found during testing.

netlify · 2026-09-23T15:39:29Z

✅ Deploy Preview for cyf-onboarding-module ready!

Name	Link
🔨 Latest commit	`3176794`
🔍 Latest deploy log	https://app.netlify.com/projects/cyf-onboarding-module/deploys/6aba3a308b79f90008e28e54
😎 Deploy Preview	https://deploy-preview-1582--cyf-onboarding-module.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	2 paths audited Performance: 100 (no change from production) Accessibility: 100 (no change from production) Best Practices: 100 (no change from production) SEO: 86 (no change from production) PWA: - View the detailed breakdown and full score reports
🤖 Make changes	Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

cjyuan · 2026-09-26T11:32:01Z

+function capitalise(str) {
+  str = `${str[0].toUpperCase()}${str.slice(1)}`;
+  return str;
+}


This work.

The alternatives of reassigning the function parameters are:

Use a separate const variable

Return the expression directly

Suggestion: Use AI to explore the trade-off of these approaches.

Thank you CJ, 1st solution is commented out, more descriptive is displayed. I did explored the differences between them.

cjyuan · 2026-09-26T11:43:52Z

+function sum(a, b) {
+  return a + b
+};


Is the semicolon on line 18 necessary?

Semicolon was deleted. I set up prettier to format text automatically.

cjyuan · 2026-09-26T11:45:46Z

+  let bmiNum = weight / (height * height)
+  bmiNum=bmiNum.toFixed(1)
+  return bmiNum


What type of value do you expect your function to return? A number or a string?
Does your function return the type of value you expect?

Different types of values may appear identical in the console output, but they are represented and treated differently in the program. For example,

console.log(123); // Output 123 console.log("123"); // Output 123 // Treated differently in the program let sum1 = 123 + 100; // Evaluate to 223 -- a number let sum 2 = "123" + 100; // Evaluate to "123100" -- a string.

I did expect it to return a string value, toFixed() method converts number to a string.

cjyuan · 2026-09-26T11:51:01Z


 function formatAs12HourClock(time) {
  const hours = Number(time.slice(0, 2));
+  const minutes = Number(time.slice(3, 5));


Note: The .slice() method supports negative indices, which count positions from the end of the string.

For example, str.slice(-3) returns the substring containing last three characters from str.

Thank you CJ, i changed value of the .slice()

cjyuan · 2026-09-26T12:02:07Z

  if (hours > 12) {
-    return `${hours - 12}:00 pm`;
+    return `${(hours - 12).toString().padStart(2, "0")}:${minutes.toString().padStart(2, "0")} pm`;
+  } else if (hours === 12) {
+    return `${hours}:${minutes.toString().padStart(2, "0")} pm`;
+  } else if (hours === 0) {
+    return `12:${minutes.toString().padStart(2, "0")} am`;
  }
  return `${time} am`;


This work.

Could also consider this approach:

Convert hours (hour in 24-hour clock) to equivalent hour in 12-hour clock and store the result in hour12.

Construct the 12 hour clock string from hour12 and minutes once.

Thanks for the suggestion. I can see how this approach would avoid repeating the same code and make the function cleaner.

cjyuan

Could you also respond to all my previous comments in addition to making change?

Suggestion: Use AI to explore "how to respond to comments in a PR".

cjyuan · 2026-09-27T20:02:26Z

+  let bmiNum = weight / (height * height);
+  bmiNum = bmiNum.toFixed(1);
+  return typeof bmiNum;
 }


Does this function return what you expect?

Thank you, I forgot to edit the code after checking the typeof bmiNum. It should return a string.

cjyuan · 2026-09-28T12:22:34Z

Changes look good.

Thanks for addressing all comments professionally.

bartoszkawiak added 9 commits September 15, 2026 14:00

Create sprint-2

b285176

Delete Sprint-2/coursework directory

ef676e6

key error 0.js completed

d0828f2

1-key-errors sprint3 completed

e67a022

2-mandatory-debug sprint3 completed

989aa0b

1-bmi completed

c0d3b07

3-mandatory-implement sprint3 completed

29c88fd

4-mandatory-interpret completed

da1df5f

sprint3-completed

eabe4c7

bartoszkawiak added 📅 Sprint 3 Assigned during Sprint 3 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Sep 23, 2026

cjyuan added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Sep 26, 2026

cjyuan reviewed Sep 26, 2026

View reviewed changes

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Sep 26, 2026

bartoszkawiak added 4 commits September 26, 2026 14:25

2-mandatory-debug formatted prettier

3fdce9e

prettier applied to the files

fc6e83d

1-key-errors 0.js another approach added

457005f

3-mandatory-implement questions answered

8473252

bartoszkawiak added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 26, 2026

cjyuan reviewed Sep 27, 2026

View reviewed changes

cjyuan removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 27, 2026

comments answered , changed return of 1-bmi.js and format-time.js

3176794

bartoszkawiak added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 28, 2026

Uh oh!

Conversation

bartoszkawiak commented Sep 23, 2026

Learners, PR Template

Task code

Changelist

Uh oh!

netlify Bot commented Sep 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for cyf-onboarding-module ready!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cjyuan left a comment

Choose a reason for hiding this comment

Uh oh!

cjyuan Sep 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cjyuan commented Sep 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

netlify Bot commented Sep 23, 2026 •

edited

Loading

cjyuan Sep 27, 2026 •

edited

Loading