Manchester | 26-ITP-Sep | Fatima Rouchi | Sprint 2 | Complete Sprint 2 Coursework - #1581
Open
fatimarouchi wants to merge 20 commits into
Open
fatimarouchi wants to merge 20 commits into
fatimarouchi wants to merge 20 commits into
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
fatimarouchi
added
the
Needs Review
hackertainment
added
Review in progress
|
Good try. Please keep it up :-) |
hackertainment
added
Reviewed
fatimarouchi
added
the
Needs Review
fatimarouchi
removed
the
Reviewed
Comment on lines
+12
to
17
| // Math.random() returns a number that's greater than or equal to 0 and less than 1. | ||
| /*Then we multiply by (maximum - minimum + 1) to get a range of possible values, which means | ||
| all the values num could end up being. In this program, num can be any whole number from 1 to 100, inclusive | ||
| so both 1 and 100 are possible.*/ | ||
| // Math.floor(...) turns that into a whole number. | ||
| // Finally, we add minimum so the number starts at minimum instead of 0. |
There was a problem hiding this comment.
Just to clarify further from your updated explanation about "so both 1 and 100 are possible" before Math.floor(...) and "Finally, we add minimum ..." after Math.floor(...), does that mean num would end up becoming range of 2 to 101 ? If not, please consider revise it a bit to improve clarity and accuracy. While this could be English presentation issue, I am just making sure that your understanding is correct. Thank you.
hackertainment
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
CYF-1039
-Completed Sprint 2 JavaScript exercises and interpretation tasks.
-Worked through errors and fixed issues in practice code.
-Improved my understanding of JavaScript basics, functions, and logic.
-Checked outputs and confirmed the solutions run correctly.