Conversation
This comment has been minimized.
This comment has been minimized.
BrianY315
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
BrianY315
added
the
Needs Review
hackertainment
added
Review in progress
|
The answers are generally correct. Keep it up. |
hackertainment
added
Reviewed
Author
|
Thanks for the review. |
|
I made comments directly on the related lines of code. Would you please fix the following issues?
Thank you. |
| const dir = ; | ||
| const ext = ; | ||
| const dir = filePath.slice(0, lastSlashIndex); | ||
| const ext = filePath.slice(filePath.lastIndexOf(".") + 1); |
There was a problem hiding this comment.
Good try. According to line 7, the . should also be part of file extension. Please fix it.
There was a problem hiding this comment.
Please breaking down the expression in line 4 and explain what it means.
Author
There was a problem hiding this comment.
I’ve added this breakdown to the comments in 4-random.js. The expression generates a random whole number from 1 to 100, inclusive. Thank you for the feedback.
| // - line 5: priceAfterOneYear.replaceAll(",", "") | ||
| // - line 4: Number(...) | ||
| // - line 5: Number(...) | ||
| // - line 9: console.log(...) |
There was a problem hiding this comment.
just a minor typo in the answer: console.log(...) should be in line 10.
| It displays a dialog box asking the user for input. | ||
|
|
||
| What is the return value of `prompt`? | ||
| The return value is the text entered by the user as a string. If the user cancels the prompt, it returns `null`. |
There was a problem hiding this comment.
Excellent, precise and concise!
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
BrianY315
added
Needs Review
|
Congratulation, you have completed this PR successfully. |
hackertainment
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Task code
CYF-1039.
Changelist
I have demonstrated and completed the Sprint 2 requirements