Manchester | 26-ITP-Sep | Mathew Shaibu | Sprint 2 | Course-work-2 by MattCarolus10 · Pull Request #1546 · CodeYourFuture/Module-JavaScript-Fundamentals

MattCarolus10 · 2026-09-19T20:37:25Z

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Task code

CYF-1039

Changelist

I have completed the "1-key-exercises" and corrected the syntax errors.
I checked for errors in the "2-Mandatory-errors" task and completed it.
I interpreted every lines of code in the "3-Mandatory-interpret" task and completed it.
I used the DevOps tool to check and research some JavaScript functions on chrome

Questions

Most functions in this project are new to me, even though I have been able to understand their functions individually, I am not really confident to code with them. I will keep practicing and any advise would really be appreciated.

netlify · 2026-09-19T20:37:29Z

✅ Deploy Preview for cyf-onboarding-module ready!

Name	Link
🔨 Latest commit	`8dfc043`
🔍 Latest deploy log	https://app.netlify.com/projects/cyf-onboarding-module/deploys/6ab957642a4a140008590f15
😎 Deploy Preview	https://deploy-preview-1546--cyf-onboarding-module.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	2 paths audited Performance: 100 (no change from production) Accessibility: 100 (no change from production) Best Practices: 100 (no change from production) SEO: 86 (no change from production) PWA: - View the detailed breakdown and full score reports
🤖 Make changes	Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

MattCarolus10 · 2026-09-24T18:06:42Z

Thank you very much

hackertainment · 2026-09-24T17:24:16Z

+const dir = filePath.slice(0, lastSlashIndex);
+console.log(`The dir part of ${filePath} is ${dir}`);
+
+const ext = base.slice(4);


The file name does not necessary 4 characters long. It can be longer and shorter (e.g. considering /path/to/screenshot.png). Cutting out the first 4 characters does not necessary remain the file extension. Please fix it, thank you.

Thank you for this review, I have checked and found out the right solution. Appreciate

The revised solution is much better. However, according to definition in line 7, the . should also be considered as file extension. So please fix this minor issue as well. Thank you.

hackertainment · 2026-09-24T17:33:15Z

+// num variable that carries the result of the expressions evaluated.
+// (maximum - minimum) does basic math: 100 - 1 + 1 = 100
+// Math.floor() takes out all decimal and make them an integer.
+// Math.random() gives random numbers between 0 and 100.
+// + minimum add 1 at the end but randomise to the value between 0 and 100


Math.random() itself does not give a number between 0 to 100.

+ minimum would not randomise value.

The explanation require a bit more details and clarity.

It would be better for your breakdown to following the same order of expression evaluation.

Please fix and elaborate you answer, thank you.

Thank you, review acknowledged

hackertainment · 2026-09-24T17:35:51Z

+const HourClockTime1 = "8:53pm";
+const hourClockTime2 = "20:53";
+console.log(`${HourClockTime1}, ${hourClockTime2}`)


While this fixed the error, can you think of better variable names? Thank you.

Variable names changed, thank you

hackertainment · 2026-09-24T17:38:36Z

+
 // e) Describe what the expression Number(carPrice.replaceAll(",","")) is doing - what is the purpose of this expression?
+
+// Answer: ReplaceAll() function clears out all the commas in the strings, the number() converts the strings to numbers to help with calculation


JavaScript is case sensitive. It should be "The Number() converts ..."

Thank. you, Error corrcted.

hackertainment · 2026-09-24T17:40:33Z

+
 // f) Try experimenting with different values of movieLength. Will this code work for all values of movieLength? Explain your answer
+
+// Answer: It will work for integer values and will give us clear and clean result using this code. However, the result would not be clean as this using float values


One more situation that make this program won't work well even an integer value is provided. Can you think of it?

I will check and make research to see

hackertainment · 2026-09-24T17:47:28Z

+// Also, line 3-6 used the function substring(0, penceString.lrength - 1) to cut out the "p" in the "penceString" variable. 
+// By starting count fron 0 (beginnning) of "399p".
+// "Using penceString.lenght - 1" to check the length of the value in the variable penceString = "399p" (4),
+//  And deducting 1 from the value (4 - 1), because length - 1 subtract 1 from the character/value count 4. leaving the value at "399"


While the result of getting "399" is correct, the explanation seems not quite accurate to me.

it is not counting, it should be indexing

the reason for deducting 1 is due to how the second parameter of substring() works

Please revise your answer. Thank you.

My explanation is due to my level of understanding, I need to work on my terminologies usage going forward. Thank you

Much clearer and more accurate now, good job! Explaining code is an important skill as a software developer, and keep practicing and you will be fine. Cheers!

hackertainment · 2026-09-24T17:50:27Z

+//  And deducting 1 from the value (4 - 1), because length - 1 subtract 1 from the character/value count 4. leaving the value at "399"
+
+// Line 8 a variable "paddedPenceNumberString" was created and a function padStart(3, "0") 
+// was used to ensure the value of the variable remains at 3 and to be filled with "0" at the beginning if the value is less 3


Your understanding might be correct but the presentation seems not quite right. What does the "value" in your explanation "the value of the variable remains at 3" mean? Can you revise the wording a bit please? Thank you.

p.s.: same issue with line 50-51 below, and please revise it as well.

Thank you so much for all your reviews, I really appreciate them and I have taken notes of the corrections.

Lines 50-51 now becomes lines 47-48, please fix them as well. Thank you.

hackertainment · 2026-09-26T14:47:17Z

+// "num" variable carries the result/value of the expressions evaluated.
+// (maximum - minimum) workout the size of the range: 100 - 1 + 1 = 100
+// Math.floor() takes out all decimal and make them a whole number from 0 to 99.
+// Math.random() gives a decimal from 0 up to just under 1 (0.9999999).
+// + minimum add 1 to the expression at the end because it is decleared a variable.


The revised explanation looks much better now. Just a few minor issues to fix further:

Math.random() inside the (... * ...) would be evaluated before Math.floor() outside of it. So it would be better to swap lines 10 and 11 in your explanation.

+ minimum at the end is not because of "it is declared a variable". This final part has its own purpose in this program. Can you think of the purpose of adding minimum at the end?

Thank you so much, I have fixed all errors now.

hackertainment · 2026-09-26T15:15:47Z

Thanks for your updated code and so far looked good to me. You are almost there and now just remaining the following issues. Would you please fix them as well?

Manchester | 26-ITP-Sep | Mathew Shaibu | Sprint 2 | Course-work-2 #1546 (comment) (this is a new comment)
Manchester | 26-ITP-Sep | Mathew Shaibu | Sprint 2 | Course-work-2 #1546 (comment) (this is a new comment)
Manchester | 26-ITP-Sep | Mathew Shaibu | Sprint 2 | Course-work-2 #1546 (comment)
Manchester | 26-ITP-Sep | Mathew Shaibu | Sprint 2 | Course-work-2 #1546 (comment) (I have also mentioned about rephrasing lines 50-51, now lines 47-48, as well which are listed below for easy reference)

// The "substring(paddedPenceNumberString.length - 2)" function deducts 3 leaving the last two numbers 99
// PadEnd(2, "0") ensure the value remains 2 and 0 to be added to value less than 2.

MattCarolus10 · 2026-09-26T15:16:58Z

I definitely will fix them. Thanks so much for reviewing my work Sent from Outlook for iOS<https://aka.ms/o0ukef>

…

________________________________ From: hackertainment ***@***.***> Sent: Saturday, 26 September 2026 16:16:08 To: CodeYourFuture/Module-JavaScript-Fundamentals ***@***.***> Cc: Mathew Shaibu ***@***.***>; Author ***@***.***> Subject: Re: [CodeYourFuture/Module-JavaScript-Fundamentals] Manchester | 26-ITP-Sep | Mathew Shaibu | Sprint 2 | Course-work-2 (PR #1546) [https://avatars.githubusercontent.com/u/259196870?s=20&v=4]hackertainment left a comment (CodeYourFuture/Module-JavaScript-Fundamentals#1546)<#1546 (comment)> Thanks for your updated code and so far looked good to me. Now just remaining the following two issues. Would you please fix them as well? * #1546 (comment)<#1546 (comment)> * #1546 (comment)<#1546 (comment)> (I have also mentioned about rephrasing line 50-51, now 47-48, as well. The lines are listed below for reference.) // The "substring(paddedPenceNumberString.length - 2)" function deducts 3 leaving the last two numbers 99 // PadEnd(2, "0") ensure the value remains 2 and 0 to be added to value less than 2. — Reply to this email directly, view it on GitHub<#1546?email_source=notifications&email_token=B4W43WLPJRRV4TVEEJ7MC535Q7MTRA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKOBUG4ZTQNZYGYYKM4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KYZTPN52GK4S7MNWGSY3L#issuecomment-5847387860>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/B4W43WILRGTKXMNHK5FAZ7L5Q7MTRAVCNFSNUABFKJSXA33TNF2G64TZHM4DSOJQGI2DGMRUHNEXG43VMU5TKNJRGM2DCMRXGQ22C5QC>. Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS<https://github.com/notifications/mobile/ios/B4W43WIZQ7VOEVLKERHNXAT5Q7MTRA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKOBUG4ZTQNZYGYYKM4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KUZTPN52GK4S7NFXXG> and Android<https://github.com/notifications/mobile/android/B4W43WOHUOFIWBPT2W35QXT5Q7MTRA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKOBUG4ZTQNZYGYYKM4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2K4ZTPN52GK4S7MFXGI4TPNFSA>. Download it today! You are receiving this because you authored the thread.Message ID: ***@***.***>

MattCarolus10 added 29 commits September 13, 2026 12:51

Hello_World JavaScript file created

919f2bc

restore password.js to prep

f93c281

1-count.js completed

9f085a5

initials.js task completed

0194cb3

file path task completed

6c5a8c8

4-random task completed

b1dcb1c

0.js error fixed

aed6985

add ; to lines

dd027fa

add ; to lines

3e2a1d2

add ; to lines

b1660fd

task 1.js completed

ed261ff

task 2.js completed

5031f8f

3.js task completed

ddc8ba6

task 4.js completed

8c577d5

percentage-change.js task completed

e44ee66

completed task 2-time-format

48b94e2

explained task 0.js

509ff84

task 1.js explained

f80c15b

task 2.js explained

7d0d970

task 3.js explained and completed

5b4ed9d

task 4.js completed and explained

c41aa67

completed and printed task 1-count.js

08af9b8

task 1-percentage-change explained

536761c

task 2-time-format.js explained and completed

276f457

3-to-pounds

4aa0e25

interpreted task 3-to-pounds.js

4cc01f5

fix: correct console log messages for base and dir parts in 3-paths.js

0a50eb5

fix: update console log for ext part in 3-paths.js

ae41a8e

task 1-kkey-exercise completed

a896a16

hackertainment added the Reviewed Volunteer to add when completing a review with trainee action still to take. label Sep 24, 2026

hackertainment reviewed Sep 25, 2026

View reviewed changes

MattCarolus10 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 25, 2026

This comment has been minimized.

Sign in to view

github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 25, 2026

MattCarolus10 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 25, 2026

This comment has been minimized.

Sign in to view

github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 25, 2026

MattCarolus10 added 4 commits September 25, 2026 17:32

random.js task fixed

973eda4

variable names changed

e29ee81

number() fixed

a675566

rephrased comments

9cbdc83

MattCarolus10 force-pushed the coursework/sprint-2 branch from 1aca2c1 to 9cbdc83 Compare September 25, 2026 16:38

MattCarolus10 added 5 commits September 25, 2026 18:00

restore Sprint-3 to upstream

a6c7eb1

remove untracked Sprint-3 files

ca8e18f

path exercises fixed

3c63ee6

comment rephrased on 3-to-pounds

a5df0de

correct spelling

31c3d98

MattCarolus10 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 25, 2026

pad time output to 2 digits

f214a57

hackertainment reviewed Sep 26, 2026

View reviewed changes

hackertainment removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 26, 2026

MattCarolus10 added 4 commits September 27, 2026 18:25

last dot index fixed

8655d17

swap line 10 and 11

b593f3e

rephrased + minimum interpret

92a5450

line 47 - 48 rephrased

8dfc043

MattCarolus10 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 27, 2026


		// e) Describe what the expression Number(carPrice.replaceAll(",","")) is doing - what is the purpose of this expression?

		// Answer: ReplaceAll() function clears out all the commas in the strings, the number() converts the strings to numbers to help with calculation


		// f) Try experimenting with different values of movieLength. Will this code work for all values of movieLength? Explain your answer

		// Answer: It will work for integer values and will give us clear and clean result using this code. However, the result would not be clean as this using float values

Uh oh!

Conversation

MattCarolus10 commented Sep 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Task code

Changelist

Questions

Uh oh!

netlify Bot commented Sep 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for cyf-onboarding-module ready!

Uh oh!

MattCarolus10 commented Sep 24, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hackertainment Sep 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

This comment has been minimized.

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hackertainment commented Sep 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MattCarolus10 commented Sep 26, 2026 via email

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

MattCarolus10 commented Sep 19, 2026 •

edited

Loading

netlify Bot commented Sep 19, 2026 •

edited

Loading

hackertainment Sep 26, 2026 •

edited

Loading

hackertainment commented Sep 26, 2026 •

edited

Loading