Skip to content

Manchester | 26-ITP-SEP | Monsur Abdulrahman | Sprint 1 | Form-controls - #1540

Open
Monsur0001 wants to merge 13 commits into
CodeYourFuture:mainfrom
Monsur0001:form-controls
Open

Monsur0001 wants to merge 13 commits into
CodeYourFuture:mainfrom
Monsur0001:form-controls

Conversation

@Monsur0001

@Monsur0001 Monsur0001 commented Sep 18, 2026 •

Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Task code

CYF-1004

Changelist

Designed and styled the Form based on the acceptance criteria.

@netlify

netlify Bot commented Sep 18, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit 6fb93d6
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/6ab7d0f032937d0007802236
😎 Deploy Preview https://deploy-preview-1540--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 86 (no change from production)
PWA: -
View the detailed breakdown and full score reports
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions

This comment has been minimized.

@Monsur0001 Monsur0001 changed the title Manchester | Sep-2026 | Monsur Abdulrahman | Sprint 1 | Form controls | CYF-1004 Manchester | 26-ITP-SEP | Monsur Abdulrahman | Sprint 1 | Form controls | CYF-1004 Sep 18, 2026
@github-actions

This comment has been minimized.

@Monsur0001 Monsur0001 added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Onboarding The name of the module. labels Sep 18, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 18, 2026
@github-actions

This comment has been minimized.

@Monsur0001 Monsur0001 changed the title Manchester | 26-ITP-SEP | Monsur Abdulrahman | Sprint 1 | Form controls | CYF-1004 Manchester | 26-ITP-SEP | Monsur Abdulrahman | Sprint 1 | Form-controls Sep 18, 2026
@github-actions

This comment has been minimized.

@Monsur0001 Monsur0001 added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Module-Onboarding The name of the module. labels Sep 18, 2026
@github-actions

This comment has been minimized.

1 similar comment
@github-actions

This comment has been minimized.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 18, 2026
@Monsur0001 Monsur0001 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 18, 2026

@cjyuan cjyuan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • According to https://validator.w3.org/, there are errors in your code. Can you fix them?

  • Your form-controls branch is 11 commits behind CYF's main. Could you update your branch, and then update your code accordingly to ensure your implementation meets the updated spec?

Comment thread Form-Controls/index.html
Comment on lines +47 to +51
<select name="color" id="color" required>
<option value="White">White</option>
<option value="Green">Green</option>
<option value="Black">Black</option>
</select>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a way to configure a <select> element so that no option is selected by default, allowing the user to make an explicit choice.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for reviewing my pull request. I have included the select option to allow the users to make choices, rather than a default option.

Comment thread Form-Controls/index.html Outdated
Comment on lines +60 to +61
<label for="xs">XS</label>
<input type="radio" name="size" id="xs" required />

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: Use AI to explore

  • Where to place the label of a radio button? Left or right? Why?
  • How to decide when to use "radio" input and when to use "select" in a HTML form?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have found out that the label of a radio button is best placed at the right. placing the label at the right puts the first line of the label directly beside the radio, which prevents overlapping when we have more lines.

Radio is used when we want the user to select just one option, and select is used when we want the users to choose more than one answer.

@cjyuan cjyuan removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 22, 2026
@cjyuan cjyuan added the Reviewed Volunteer to add when completing a review with trainee action still to take. label Sep 22, 2026
@Monsur0001 Monsur0001 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 26, 2026
@cjyuan

cjyuan commented Sep 26, 2026

Copy link
Copy Markdown
Contributor

Your form-controls branch is 11 commits behind CYF's main. Could you update your branch, and then update your code accordingly to ensure your implementation meets the updated spec? If not, could you take a look at the updated spec in README.md and then ensure your implementation meets all the new requirements?

Other changes are good.

@cjyuan cjyuan removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Reviewed Volunteer to add when completing a review with trainee action still to take.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants