Manchester | 26-ITP-SEP | Monsur Abdulrahman | Sprint 1 | Form-controls - #1540
Monsur0001 wants to merge 13 commits into
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
cjyuan
left a comment
There was a problem hiding this comment.
-
According to https://validator.w3.org/, there are errors in your code. Can you fix them?
-
Your
form-controlsbranch is 11 commits behind CYF's main. Could you update your branch, and then update your code accordingly to ensure your implementation meets the updated spec?
| <select name="color" id="color" required> | ||
| <option value="White">White</option> | ||
| <option value="Green">Green</option> | ||
| <option value="Black">Black</option> | ||
| </select> |
There was a problem hiding this comment.
There is a way to configure a <select> element so that no option is selected by default, allowing the user to make an explicit choice.
There was a problem hiding this comment.
Thank you for reviewing my pull request. I have included the select option to allow the users to make choices, rather than a default option.
| <label for="xs">XS</label> | ||
| <input type="radio" name="size" id="xs" required /> |
There was a problem hiding this comment.
Suggestion: Use AI to explore
- Where to place the label of a radio button? Left or right? Why?
- How to decide when to use "radio" input and when to use "select" in a HTML form?
There was a problem hiding this comment.
I have found out that the label of a radio button is best placed at the right. placing the label at the right puts the first line of the label directly beside the radio, which prevents overlapping when we have more lines.
Radio is used when we want the user to select just one option, and select is used when we want the users to choose more than one answer.
|
Your form-controls branch is 11 commits behind CYF's main. Could you update your branch, and then update your code accordingly to ensure your implementation meets the updated spec? If not, could you take a look at the updated spec in Other changes are good. |

Learners, PR Template
Self checklist
Task code
CYF-1004
Changelist
Designed and styled the Form based on the acceptance criteria.