Manchester | 26-ITP-Sep | Precious Moses | Sprint 2 | Course-work-2 - #1537
moses77-boop wants to merge 84 commits into
Conversation
…rd in passwordChecker.js
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Just need to fix |
|
|
It would be nice to pay more attention to details, as I still see the trailing space in your fix. In a larger system, one space can make a big difference or could even create security issues - especially trailing space is not easily visible. Hope you would appreciate the importance of building up a good programming practice conforming to industry standard for every software developers. Thank you. |
|
|
||
| const initials = ``; | ||
| //Solution | ||
| const initials = `${firstName[0]} ${middleName[0]} ${lastName[0]} `; |
There was a problem hiding this comment.
Read line 6 carefully, as there should be no space between initials (i.e. should be CJK but not C J K ). Please fix it, thank you.
There was a problem hiding this comment.
I'm positive about fixing this issue.
Please reconfirm.
Thank you
|
|
||
| //-(maximum - minimum + 1): | ||
| // This expression can be simplified as (100 - 1 + 1), which equals 100. This tells the program how many possible whole numbers there are. There are 100 possibilities. | ||
| // The +1 is important as without it, we would only reach 99 possibilities, that is 0 - 99. |
There was a problem hiding this comment.
0 - 99 are 100 possibilities, not 99 possibilities - but I got what you mean.
| // Line 4: Number() | ||
| // Line 5: priceAfterOneYear.replaceAll("," "") | ||
| // Line 5: Number() | ||
| // Line 9: console.log() |
There was a problem hiding this comment.
console.log() should be in line 10 - but I got what you mean.
There was a problem hiding this comment.
Thanks for the feedback!
It has been resolved.
|
Congratulation, you have completed this PR successfully. |

Self checklist
Task code
CYF-1039
Changelist
Completed the sprint 2 course work which included the use of assignment operators, arrays, methods, functions, strings and objects.