Skip to content

Manchester | 26-ITP-Sep | Precious Moses | Sprint 2 | Course-work-2 - #1537

Open
moses77-boop wants to merge 84 commits into
CodeYourFuture:mainfrom
moses77-boop:coursework/sprint-2
Open

moses77-boop wants to merge 84 commits into
CodeYourFuture:mainfrom
moses77-boop:coursework/sprint-2

Conversation

@moses77-boop

@moses77-boop moses77-boop commented Sep 18, 2026 •

Copy link
Copy Markdown

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Task code

CYF-1039

Changelist

Completed the sprint 2 course work which included the use of assignment operators, arrays, methods, functions, strings and objects.

@netlify

netlify Bot commented Sep 18, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit 01284c0
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/6ab685ec0435190008a5f5a0
😎 Deploy Preview https://deploy-preview-1537--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 86 (no change from production)
PWA: -
View the detailed breakdown and full score reports
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions

This comment has been minimized.

@moses77-boop moses77-boop added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 18, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 18, 2026
moses77-boop

This comment was marked as resolved.

@moses77-boop moses77-boop added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. 📅 Sprint 2 Assigned during Sprint 2 of this module labels Sep 18, 2026
@hackertainment hackertainment added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Sep 24, 2026
@hackertainment

Copy link
Copy Markdown

Just need to fix Sprint-2/1-key-exercises/2-initials.js , thank you.

@hackertainment hackertainment added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Sep 24, 2026
@moses77-boop

Copy link
Copy Markdown
Author

Just need to fix Sprint-2/1-key-exercises/2-initials.js , thank you.

done! 👍

@hackertainment

Copy link
Copy Markdown

It would be nice to pay more attention to details, as I still see the trailing space in your fix. In a larger system, one space can make a big difference or could even create security issues - especially trailing space is not easily visible. Hope you would appreciate the importance of building up a good programming practice conforming to industry standard for every software developers. Thank you.

Comment thread Sprint-2/1-key-exercises/2-initials.js Outdated

const initials = ``;
//Solution
const initials = `${firstName[0]} ${middleName[0]} ${lastName[0]} `;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read line 6 carefully, as there should be no space between initials (i.e. should be CJK but not C J K ). Please fix it, thank you.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm positive about fixing this issue.
Please reconfirm.
Thank you


//-(maximum - minimum + 1):
// This expression can be simplified as (100 - 1 + 1), which equals 100. This tells the program how many possible whole numbers there are. There are 100 possibilities.
// The +1 is important as without it, we would only reach 99 possibilities, that is 0 - 99.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0 - 99 are 100 possibilities, not 99 possibilities - but I got what you mean.

// Line 4: Number()
// Line 5: priceAfterOneYear.replaceAll("," "")
// Line 5: Number()
// Line 9: console.log()

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

console.log() should be in line 10 - but I got what you mean.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback!
It has been resolved.

@hackertainment

hackertainment commented Sep 26, 2026 •

Copy link
Copy Markdown

Congratulation, you have completed this PR successfully.

@hackertainment hackertainment added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Sep 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. 📅 Sprint 2 Assigned during Sprint 2 of this module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants