Repository navigation
Update rust version to 1.88 and fix some clippy warnings - #62
Merged
Merged
Conversation
rustfmt code to match. Signed-off-by: Matt Johnston <matt@codeconstruct.com.au>
Crates and the workspace now specify the rust-version, and README documents it. Signed-off-by: Matt Johnston <matt@codeconstruct.com.au>
Recent clippy nightly recommended using `while let`. The loop break can be simplified as well. No functional change. Signed-off-by: Matt Johnston <matt@codeconstruct.com.au>
Nightly clippy suggests FromStr, so add that. Signed-off-by: Matt Johnston <matt@codeconstruct.com.au>
Suggested by clippy. Signed-off-by: Matt Johnston <matt@codeconstruct.com.au>
Signed-off-by: Matt Johnston <matt@codeconstruct.com.au>
Contributor
|
I think it's probably best that the noise from CI is dealt with, as it's not going to go away of its own accord. I feel the use of Deku's latest tag has an MSRV of 1.82. There are bumps to 1.88 beyond the tag. I guess whether 1.88 is necessary depends on our needs when updating the dependency? That said, I don't have any immediate personal concerns. I run debian stable but use rustup to manage rust toolchains, so the MSRV bump past trixie's toolchain won't cause me problems, though it may be a concern for others. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the rust version to 1.88 and edition 2024. @amboar @jk-ozlabs does that seem OK?
That version seems suitable given it will be needed if we want to use latest deku at some point.
The motivation is to avoid clippy warnings in the daily-nightly CI job. Setting the workspace and Cargo.toml versions to 1.85 might be another option (but won't get the while let/if let cleanups).