You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Summary
Forward-ports the 0.9.9 patch (PR #3073) to main, which was merged against the v0.9.9 branch and never reached main/0.10.0 (tracked in #3136). Two fixes for #2637: (1) in client-v2, server error 159 TIMEOUT_EXCEEDED is removed from the retryable set in ServerException.discoverIsRetryable(), so execution timeouts are no longer retried unconditionally; (2) in jdbc-v2, Statement.setQueryTimeout() now sets the max_execution_time server setting when the client runs in sync mode (the default), where the previous future-based timeout had no effect, and timeout failures now surface as SQLTimeoutException (a SQLException subclass) via a new throwOnExecutionTimeout path in StatementImpl. ConnectionImpl additionally now applies DEFAULT_QUERY_SETTINGS driver property and server_setting-prefixed client properties to connection-level default query settings, with statement-level timeout override/reset semantics. Substantial integration test coverage added in both modules.
What this impacts
client-v2 retry policy: error 159 no longer retriable (behavioral change for all client-v2 users).
jdbc-v2Statement#setQueryTimeout semantics: now maps to server-side max_execution_time in sync mode; throws SQLTimeoutException instead of generic SQLException on timeout.
jdbc-v2ConnectionImpl: connection-level server settings from driver/client properties now populate default query settings.
Behavioral change in two hot-path modules (client-v2 retry logic, jdbc-v2 statement execution) — fires the Medium rule; stays below the High cross-module threshold (2 of the listed modules, 341 changed lines).
Bundled out-of-scope changes: DatabaseMetaDataImpl engine-map additions (Paimon, Remote, etc.) and the StatementSQLTests.yaml change (EXPLAIN → EXPLAIN AST) are unrelated to the timeout fix and aren't mentioned in the PR body or linked issues.
ConnectionImpl now propagates server_setting-prefixed properties into default query settings — effectively a changed default behavior for existing connection strings; worth a human sanity check for double-application of settings.
New timing-based assertions (Math.abs(elapsed - expected) < 1000) across several integration tests may be flaky on slow CI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes: #2637
Closes: #3136
Closes: #2826
Checklist
Delete items not relevant to your PR: