Repository navigation
Catch UnicodeDecodeErrors if invalid utf-8 data is sent - #182
Merged
Merged
Conversation
simon-ess
force-pushed
the
catch_unicde_error
branch
3 times, most recently
from
October 5, 2026 12:49
69c91f5 to
865f156
Compare
jacomago
reviewed
Oct 5, 2026
| log.error("Ignoring info update") | ||
| return self.getInitialState() | ||
| except messages.KeyValueDecodeError as e: | ||
| log.error("Error decoding key/value pair: '{}': '{}'", e.key, e.value) |
Contributor
There was a problem hiding this comment.
probably swap to
log.exception("Error decoding key/value pair: '{}': '{}'", e.key, e.value)
Contributor
Author
There was a problem hiding this comment.
Fixed. Also add host/port to log message since we've noted that we are often missing this.
simon-ess
force-pushed
the
catch_unicde_error
branch
from
October 6, 2026 06:58
865f156 to
5bab7f6
Compare
|
jacomago
approved these changes
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This applies to both record names and info tags.