Repository navigation
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
- Added reusable middleware (passthrough.js) for Authorization resolution and kill‑switch enforcement. - Updated token handling to bypass refresh when client token is present. - Modified create and update routes to use new middleware and forward Authorization header. - Updated README with Passthrough Token Mode documentation and Mermaid diagram. - Added test to verify Authorization header forwarding. - Prepared for full route coverage (delete, overwrite pending).
Member
|
argh |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The existing Passthrough Token implementation duplicated logic across routes and used a placeholder Authorization header, causing maintenance overhead and potential errors. A modular approach improves consistency and makes future extensions easier.
What was done
passthrough.jsprovidingresolveAuthorizationandrequirePassthroughAllowedmiddleware.tokens.jsto bypass token refresh when a client-supplied Authorization header is present.createandupdateroutes to import the new helpers, enforce the kill‑switch before token checks, and forward the exact client Authorization header.test/routes/passthrough.test.jsto verify header forwarding.deleteandoverwriteroutes (imports added, pending final header replacement).Notes
ALLOW_PASSTHROUGH_TOKENSenvironment variable, returning 403 when disabled.Checklist
deleteandoverwriteroutes (planned for subsequent PR)