Repository navigation
ci: build and test GPUI desktop on Intel macOS - #2698
Merged
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
richiemcilroy
force-pushed
the
ci/gpui-intel-macos
branch
from
October 18, 2026 18:38
3fe9a93 to
b335f7c
Compare
Member
Author
|
@greptileai review |
richiemcilroy
marked this pull request as ready for review
October 19, 2026 09:02
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A nightly crashed for a user on an Intel Mac (MacBookPro16,3, macOS 15, x86_64). CI only builds and tests the GPUI app on Apple Silicon, Windows and Linux, so nothing catches breakage that only shows up on x86_64 macOS before a release ships it. The Intel release build is cross-compiled on an Apple Silicon runner, so its code never actually runs anywhere in CI.
What this adds:
x86_64-apple-darwinentry in theBuild GPUI Desktopmatrix inci.yml, so it uses the same path filter, setup, rust cache flavour (v1-rust-gpui, keyed by target and runner arch) and steps as the other lanes.scripts/setup.jsalready picks the x86_64 native deps (FFmpeg framework) and ONNX Runtime fromRUST_TARGET_TRIPLE, the same way the Intel release build does.cargo test --bin cap-gpuiandcargo test -p cap-gpui-kernels. That also covers the Intel-only code paths behindcfg(all(target_os = "macos", target_arch = "x86_64")), which no test ran before.Runner and duration:
macos-26-intel, the newest GitHub-hosted Intel image (macos-15-intelis the only other one). Blacksmith has no Intel Macs.cap-gpui(the arm64 lane runs 3 more tests that are compiled out on Intel macOS), and 31 passed forcap-gpui-kernels.Engine verify on Intel is left out for now. It would need a new platform in
scripts/verify/suites.jsonwith its own case floors, and hosted Intel VMs have no usable GPU or hardware video decode, so it is better as an optional follow-up than a required check.

Confidence Score: 5/5
The PR appears safe to merge; no blocking issues were found.Summary
Adds native Intel macOS coverage to the existing GPUI desktop CI job.
No actionable issues were found.
Reviews (2) · Last reviewed commit: "ci: build and test GPUI desktop on Intel..." · Reviewed by Greptile