Repository navigation
ci(verify): Windows real capture records its cache manifest, and a cached build without one is rebuilt - #2693
Merged
Conversation
…ched build without one is rebuilt
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Member
Author
|
@greptileai review |
richiemcilroy
marked this pull request as ready for review
October 18, 2026 01:39
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
#2691's Windows real-capture job failed to compile:
unresolved import cap_enc_ffmpeg::remux::get_video_capture_fps(run 39084495635). Its checkout had that function, merged in #2689. Cargo never rebuiltcap-enc-ffmpegand linked a cached build from before it.The cause is the Windows real-capture job I added in #2667. It saves the shared
verify-build-v3-x86_64-pc-windows-msvc-github-hostedcache without runningmtime.py record, so the cache has no source manifest. The next restore finds a cachedtarget/ci-verifyand no manifest, and takes the cold-build path. That path gives every source file the fixed 2000-01-01 time, so cargo treats every cached crate as fresh, including ones whose sources changed. The log shows it:no manifest at target/ci-verify/verify-src-manifest.txt: cold build, normalising every file/4852 files unchanged since the cached build, 0 changed or new.Fix
I deleted the nine manifest-less PR and branch caches (about 10 GB).
Checked
mtime.pyrun in a scratch repo:rebuilding every crate, and both files get the current time;

Confidence Score: 5/5
The PR appears safe to merge.Summary
The Windows real-capture job now records source contents before saving its build cache and stops saving caches from pull requests.
Reviews (2) · Last reviewed commit: "ci(verify): Windows real capture records..." · Reviewed by Greptile