Repository navigation
fix(project): keep legacy captions that end at the timeline end - #2683
Open
yashranaway wants to merge 2 commits into
Open
yashranaway wants to merge 2 commits into
yashranaway wants to merge 2 commits into
Conversation
Contributor
Author
|
@greptileai review |
Contributor
|
@yashranaway is attempting to deploy a commit to the Cap Software Inc Team on Vercel. A member of the Team first needs to authorize it. |
yashranaway
force-pushed
the
fix/legacy-caption-end
branch
from
October 18, 2026 18:46
54ff1d3 to
c1a5415
Compare
Contributor
Author
|
@greptileai review |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is the legacy caption migration case from the verify expectations. loading an older project dropped a caption that ends exactly at the timeline end. the end time got mapped back through the clip math, which after a transition lands a hair under the real end, so it didn't map and the whole caption was thrown away.
now a time that equals the saved timeline end maps straight to the last source endpoint, no tolerance needed, and times past the end are still rejected. the xfail entry is removed and both migration cases pass, including the 1000 random runs.
🤖 Generated with Claude Code


Confidence Score: 5/5
The PR appears safe to merge; no actionable issues were found.Summary
Keeps legacy captions and words whose end equals the timeline’s rounded end by mapping that time directly to the final clip’s source endpoint.
Reviews (2) · Last reviewed commit: "fix(project): keep legacy captions at th..." · Reviewed by Greptile