Skip to content

fix(project): keep legacy captions that end at the timeline end - #2683

Open
yashranaway wants to merge 2 commits into
CapSoftware:mainfrom
yashranaway:fix/legacy-caption-end
Open

yashranaway wants to merge 2 commits into
CapSoftware:mainfrom
yashranaway:fix/legacy-caption-end

Conversation

@yashranaway

@yashranaway yashranaway commented Oct 17, 2026 •

Copy link
Copy Markdown
Contributor

this is the legacy caption migration case from the verify expectations. loading an older project dropped a caption that ends exactly at the timeline end. the end time got mapped back through the clip math, which after a transition lands a hair under the real end, so it didn't map and the whole caption was thrown away.

now a time that equals the saved timeline end maps straight to the last source endpoint, no tolerance needed, and times past the end are still rejected. the xfail entry is removed and both migration cases pass, including the 1000 random runs.

🤖 Generated with Claude Code

RetriggerView in GreptileConfidence Score: 5/5

The PR appears safe to merge; no actionable issues were found.

Summary

Keeps legacy captions and words whose end equals the timeline’s rounded end by mapping that time directly to the final clip’s source endpoint.

  • Legacy captions ending at the timeline end keep their final words.

Reviews (2) · Last reviewed commit: "fix(project): keep legacy captions at th..." · Reviewed by Greptile

@yashranaway

Copy link
Copy Markdown
Contributor Author

@greptileai review

@vercel

vercel Bot commented Oct 17, 2026

Copy link
Copy Markdown
Contributor

@yashranaway is attempting to deploy a commit to the Cap Software Inc Team on Vercel.

A member of the Team first needs to authorize it.

@yashranaway
yashranaway force-pushed the fix/legacy-caption-end branch from 54ff1d3 to c1a5415 Compare October 18, 2026 18:46
@yashranaway

Copy link
Copy Markdown
Contributor Author

@greptileai review

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants