Repository navigation
fix(recording): recover footage after an early muxer restart - #2678
Merged
richiemcilroy merged 2 commits intoOct 18, 2026
Merged
richiemcilroy merged 2 commits into
richiemcilroy merged 2 commits into
Conversation
Contributor
Author
|
@greptileai review |
Contributor
|
@yashranaway is attempting to deploy a commit to the Cap Software Inc Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
if the recording muxer restarted before finishing its first fragment, all the screen footage ended up in the restart folder and the main folder only had a half written fragment. recovery checked the main folder, found nothing complete, and said there was nothing to recover, so the whole recording was lost even though the footage was right there.
now recovery looks in the restart folders when the main one is empty, and finishing doesn't give up on an empty first group before checking them. tests use real encoded fixtures, including a cut off tail and a corrupt restart.
🤖 Generated with Claude Code


Confidence Score: 5/5
The PR appears safe to merge; no actionable issues were found.Summary
Recovery now finds display footage in restart folders when the original folder has no usable fragments.
Tests were reviewed but not executed.
Reviews (1) · Last reviewed commit: "fix(recording): recover footage after an..." · Reviewed by Greptile