Skip to content

fix(recording): recover footage after an early muxer restart - #2678

Merged
richiemcilroy merged 2 commits into
CapSoftware:mainfrom
yashranaway:fix/recovery-restart-only-footage
Oct 18, 2026
Merged

richiemcilroy merged 2 commits into
CapSoftware:mainfrom
yashranaway:fix/recovery-restart-only-footage

Conversation

@yashranaway

@yashranaway yashranaway commented Oct 17, 2026 •

Copy link
Copy Markdown
Contributor

if the recording muxer restarted before finishing its first fragment, all the screen footage ended up in the restart folder and the main folder only had a half written fragment. recovery checked the main folder, found nothing complete, and said there was nothing to recover, so the whole recording was lost even though the footage was right there.

now recovery looks in the restart folders when the main one is empty, and finishing doesn't give up on an empty first group before checking them. tests use real encoded fixtures, including a cut off tail and a corrupt restart.

🤖 Generated with Claude Code

RetriggerView in GreptileConfidence Score: 5/5

The PR appears safe to merge; no actionable issues were found.

Summary

Recovery now finds display footage in restart folders when the original folder has no usable fragments.

  • Studio recovery finds video stored in numbered restart folders.

Tests were reviewed but not executed.

Reviews (1) · Last reviewed commit: "fix(recording): recover footage after an..." · Reviewed by Greptile

@yashranaway

Copy link
Copy Markdown
Contributor Author

@greptileai review

@vercel

vercel Bot commented Oct 17, 2026

Copy link
Copy Markdown
Contributor

@yashranaway is attempting to deploy a commit to the Cap Software Inc Team on Vercel.

A member of the Team first needs to authorize it.

@richiemcilroy
richiemcilroy merged commit c74c6bb into CapSoftware:main Oct 18, 2026
44 of 46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants