Repository navigation
fix(rendering): preserve chroma at odd frame edges - #2613
Merged
Merged
Conversation
Contributor
|
@yashranaway is attempting to deploy a commit to the Cap Software Inc Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
Author
|
@greptileai review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
videos with an odd width or height lost the last row or column of colour data on the gpu path. the decoder copied the chroma planes using height / 2, the frame slicing did the same, and the gpu upload used width / 2, so for something like 17x9 the bottom and right edge got the wrong colour (a 1x1 frame came out green).
it now uses ffmpeg's own plane heights when copying and rounds up everywhere else, for both yuv420p and nv12, padded strides included. the cpu path already rounds up, so the two agree now. two tests cover it, one checks the copied planes and one compares gpu output against an even sized frame on llvmpipe. both fail on main.
🤖 Generated with Claude Code


Confidence Score: 5/5
The PR appears safe to merge; no actionable issues were found.Summary
Preserves edge colors in odd-sized YUV420P and NV12 frames.
No actionable issues found. Tests were reviewed but not run.
Reviews (1) · Last reviewed commit: "fix(rendering): preserve chroma at odd f..." · Reviewed by Greptile