Skip to content

fix(editor): apply audio sync offsets during playback - #2612

Merged
richiemcilroy merged 2 commits into
CapSoftware:mainfrom
yashranaway:fix/editor-playback-audio-offsets
Oct 18, 2026
Merged

richiemcilroy merged 2 commits into
CapSoftware:mainfrom
yashranaway:fix/editor-playback-audio-offsets

Conversation

@yashranaway

@yashranaway yashranaway commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

changing the mic or system audio offset while the editor is playing kept playing the old audio until you stopped and started again. the check that decides whether playback has to re-render its audio after an edit looked at clip timing, speed and volume, but not those offsets.

it now also compares the mic and system audio offsets of the clip each timeline segment plays, using the same lookup the audio renderer does. camera offset edits and clips the timeline doesn't use still don't trigger a refresh. two tests cover both sides, and the offset one fails on main.

🤖 Generated with Claude Code

RetriggerView in GreptileConfidence Score: 5/5

The PR appears safe to merge; no actionable issues were found.

Summary

Playback now detects microphone and system-audio offset edits without requiring a stop and restart.

  • Mic and system audio edits refresh playback audio while it runs.

No actionable issues found. Tests were not run.

Reviews (1) · Last reviewed commit: "fix(editor): apply audio sync offsets du..." · Reviewed by Greptile

@yashranaway

Copy link
Copy Markdown
Contributor Author

@greptileai review

@vercel

vercel Bot commented Oct 15, 2026

Copy link
Copy Markdown
Contributor

@yashranaway is attempting to deploy a commit to the Cap Software Inc Team on Vercel.

A member of the Team first needs to authorize it.

@richiemcilroy
richiemcilroy merged commit 8b799aa into CapSoftware:main Oct 18, 2026
43 of 45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants