Repository navigation
fix(editor): apply audio sync offsets during playback - #2612
Merged
richiemcilroy merged 2 commits intoOct 18, 2026
Merged
richiemcilroy merged 2 commits into
richiemcilroy merged 2 commits into
Conversation
Contributor
Author
|
@greptileai review |
Contributor
|
@yashranaway is attempting to deploy a commit to the Cap Software Inc Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changing the mic or system audio offset while the editor is playing kept playing the old audio until you stopped and started again. the check that decides whether playback has to re-render its audio after an edit looked at clip timing, speed and volume, but not those offsets.
it now also compares the mic and system audio offsets of the clip each timeline segment plays, using the same lookup the audio renderer does. camera offset edits and clips the timeline doesn't use still don't trigger a refresh. two tests cover both sides, and the offset one fails on main.
🤖 Generated with Claude Code


Confidence Score: 5/5
The PR appears safe to merge; no actionable issues were found.Summary
Playback now detects microphone and system-audio offset edits without requiring a stop and restart.
No actionable issues found. Tests were not run.
Reviews (1) · Last reviewed commit: "fix(editor): apply audio sync offsets du..." · Reviewed by Greptile