Skip to content

fix(audio): count buffered timestamp gaps only once - #2609

Merged
richiemcilroy merged 2 commits into
CapSoftware:mainfrom
yashranaway:fix/audio-media
Oct 18, 2026
Merged

richiemcilroy merged 2 commits into
CapSoftware:mainfrom
yashranaway:fix/audio-media

Conversation

@yashranaway

@yashranaway yashranaway commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

when mic audio has two or more timestamp gaps waiting in the encoder's resample buffer, the buffer counted the first gap again for every later chunk. so it thought it had more audio than it did and handed the encoder a full aac/opus frame before that audio existed, with the end of the frame never written.

it now moves its position past each gap once. two tests cover it: a request one sample bigger than what's buffered used to succeed, and a flush after a partial read came out 100 samples too long. both fail on main.

🤖 Generated with Claude Code

RetriggerView in GreptileConfidence Score: 5/5

The PR appears safe to merge.

Summary

Fixes BufferedResampler so a buffered timestamp gap is not counted again for later frames.

  • Buffered audio counts each timestamp gap only once.

Static review found no actionable issues. Tests were not run.

Reviews (1) · Last reviewed commit: "fix(audio): count buffered timestamp gap..." · Reviewed by Greptile

@yashranaway

Copy link
Copy Markdown
Contributor Author

@greptileai review

@vercel

vercel Bot commented Oct 15, 2026

Copy link
Copy Markdown
Contributor

@yashranaway is attempting to deploy a commit to the Cap Software Inc Team on Vercel.

A member of the Team first needs to authorize it.

@richiemcilroy
richiemcilroy merged commit 6152683 into CapSoftware:main Oct 18, 2026
45 of 47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants