Repository navigation
fix(audio): count buffered timestamp gaps only once - #2609
Merged
Merged
Conversation
Contributor
Author
|
@greptileai review |
Contributor
|
@yashranaway is attempting to deploy a commit to the Cap Software Inc Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when mic audio has two or more timestamp gaps waiting in the encoder's resample buffer, the buffer counted the first gap again for every later chunk. so it thought it had more audio than it did and handed the encoder a full aac/opus frame before that audio existed, with the end of the frame never written.
it now moves its position past each gap once. two tests cover it: a request one sample bigger than what's buffered used to succeed, and a flush after a partial read came out 100 samples too long. both fail on main.
🤖 Generated with Claude Code


Confidence Score: 5/5
The PR appears safe to merge.Summary
Fixes
BufferedResamplerso a buffered timestamp gap is not counted again for later frames.Static review found no actionable issues. Tests were not run.
Reviews (1) · Last reviewed commit: "fix(audio): count buffered timestamp gap..." · Reviewed by Greptile