Repository navigation
quality presets: resolved against the GPU's class (device profile) - #194
Open
proggeramlug wants to merge 1 commit into
Open
proggeramlug wants to merge 1 commit into
proggeramlug wants to merge 1 commit into
Conversation
A preset names a tier relative to the device, as Unreal's device profiles resolve scalability per GPU family. gpu_class() sorts the adapter by name: Low for mobile GPUs a generation or more below current mid-range (Adreno below 640, Mali-T and Mali-G below G76, PowerVR), Standard otherwise; BLOOM_GPU_CLASS=low|standard overrides it. On a Low GPU no tier pays for the full-resolution composite sharpen, SSAO, SSR or SSGI; TAA, shadows, bloom and the render scale stay as the tier sets them. Pixel 4a (Adreno 618), tuichess: medium 12.7 -> 16.0 fps, low 15.4 -> 17.1 fps (the sharpen was 6 ms and SSAO 7 ms of a ~70 ms frame).
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 3 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A quality preset now names a tier relative to the device, the way Unreal's device profiles resolve scalability per GPU family.
Renderer::gpu_class()sorts the adapter by its name:BLOOM_GPU_CLASS=low|standardoverrides it.On a Low GPU,
apply_quality_presetleaves out the full-resolution composite sharpen, SSAO, SSR and SSGI at every tier. TAA, shadows, bloom and the render scale stay as the tier sets them. On a Pixel 4a (Adreno 618) at render scale 0.5, the sharpen alone was 6 ms and SSAO 7 ms of a ~70 ms frame, more than the rest of the post chain together. Standard GPUs get exactly the presets as before (tested).Pixel 4a, tuichess at default settings:
New tests cover the class rules (Adreno, Mali, PowerVR, Apple, NVIDIA names) and the profile: on Low only the costly post effects change; on Standard nothing does.