Repository navigation
taa: a fast tier, the default on Android - #191
Merged
Merged
Conversation
set_taa_fast selects fs_main_fast: the current pixel as rendered, history clamped to the YCoCg variance of the pixel and its 4-neighbour cross, one bilinear history fetch reprojected by the closest-depth velocity (the sky by its direction), the same blend weight. The low tier of temporal AA (Unreal's lowest r.TemporalAA.Quality), for TAA resolving at the render resolution: none of the full shader's reconstruction filters or provenance and lock heuristics. Pixel 4a, 0.5 render scale: TAA 16 -> 4 ms, no visible ghosting while the camera turns. The TAA pipeline descriptor is shared by both entry points.
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 10 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #188 (TAA at the render resolution); retarget to
mainonce that lands.set_taa_fastselects a new entry point in the TAA shader,fs_main_fast. It is the low tier of temporal AA, like Unreal's lowestr.TemporalAA.Quality:It doesn't run the full shader's Catmull-Rom/Lanczos reconstruction, sharpened history, depth-provenance rejection or detail-lock heuristics. It is meant for TAA resolving at the render resolution (
set_temporal_upscale(false)). It writes the same two targets: the provenance keeps the depth key and reports no confidence.Default on Android, off elsewhere. Desktop is unchanged.
Pixel 4a (Adreno 618), tuichess at 0.5 render scale: TAA 16 → 4 ms. The static image matches the full TAA, and there's no visible ghosting while the camera turns (captured mid-drag). The TAA pipeline descriptor is now one closure shared by both entry points, so
mod.rsstays at its line baseline.cargo test --libpasses.