Repository navigation
ssao: Hi-Z mip per march step without a private array - #190
Open
proggeramlug wants to merge 1 commit into
Open
proggeramlug wants to merge 1 commit into
proggeramlug wants to merge 1 commit into
Conversation
The per-pixel mip_per_step array was indexed by the step counter: a runtime-indexed private array is function memory in SPIR-V, which Adreno keeps in scratch memory. Each step computes its mip (floor(log2) of the pixels it covers) instead; same values. Pixel 4a: SSAO 8 -> 7 ms.
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 31 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The GTAO march read each step's Hi-Z mip from
var<private> mip_per_step: array<i32, 8>, indexed by the step counter. A runtime-indexed private array becomes function memory in SPIR-V, which Adreno keeps in scratch memory (the same issue as #184). Each step now computes its mip directly,clamp(floor(log2(step_pixels * s)), 0, HIZ_MAX_MIP), giving the same values as the precomputed table.On a Pixel 4a (Adreno 618) the SSAO pass goes from 8 to 7 ms at 0.5 render scale.
cargo test --libpasses.