Repository navigation
text: only a font's Unicode cmaps (ü drew as ¸ in Menlo on iOS/tvOS) - #187
Open
proggeramlug wants to merge 1 commit into
Open
proggeramlug wants to merge 1 commit into
proggeramlug wants to merge 1 commit into
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 11 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fontdue merges every cmap subtable of a font, later ones overwriting earlier ones. Menlo (
/System/Library/Fonts/CoreUI/Menlo.ttc, the iOS/tvOSmonospace) has a Unicode table followed by a legacy Mac Roman one, so U+00FC "ü" took Mac Roman byte 0xFC (the cedilla "¸") and "ä" took 0xE4 ("‰"). In the Chesslings app German buttons read "Zur¸ck" and "Men¸".load_fontnow hands fontdue a copy whose cmap header lists only the Unicode encoding records (platform 0, or 3 with encoding 0/1/10). Fonts that have no Unicode map, or only Unicode maps, are passed through unchanged (no copy).Test:
cmap_tests::mac_roman_cmap_does_not_override_unicode(uses macOS's Menlo, same cmap layout as the iOS one; skipped where the file is missing).