Repository navigation
android: lifecycle review follow-ups - #186
Merged
Merged
Conversation
- A window set only through bloom_android_set_native_window is the current one too, so the first frame keeps it. - The surface's GPU work (dropping, creating, configuring) runs outside the lifecycle lock, so nativeSurfaceLost/nativeSetSurface never wait on it; the game thread takes a window over under the lock before using it. - nativeSetSurface releases the extra reference when it hands over a window already held. - The finger that went down first drives mouse button 0 until it lifts (POINTER_UP of that finger releases it). - Audio stays paused when the surface wait ends for a close request. - The logcat reader retries an interrupted read, logs a partial last line at EOF and closes its end. - nativeMain clears a close request left by an earlier Activity.
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 21 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-ups to #182 from its last review round.
bloom_android_set_native_window(Perry's host path) is the current one too, so the first frame keeps it instead of dropping the surface.nativeSurfaceLost/nativeSetSurfacenever wait on a slow device idle. The game thread takes a window over under the lock before using it, so the UI thread can't release it meanwhile.nativeSetSurfacereleases the extra reference when it hands over a window already held.read, logs a partial last line at EOF and closes its end.nativeMainclears a close request left by an earlier Activity in the same process.Tested on a Pixel 4a: launch, background and resume (twice), taps, Back.