Repository navigation
Fix inconsistency in SDK - #186
Merged
Merged
Conversation
ikripaka
force-pushed
the
fix/issues
branch
6 times, most recently
from
October 21, 2026 19:18
ff183af to
001f229
Compare
ikripaka
marked this pull request as ready for review
October 22, 2026 07:13
LesterEvSe
requested changes
Oct 22, 2026
* add errors instead of panic * add additional tests to catch this behaviour
LesterEvSe
approved these changes
Oct 22, 2026
Collaborator
Author
|
Rebased onto current dev dc7b26d. |
fix: * hash collisions on deps installation * overlapping cloning behaviour (tag and branch) * dependency escaping issue
Arvolear
reviewed
Oct 23, 2026
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves some inconsistencies in the SDK.
ddcf727 - resolves an unblinding issue when TxOutSecret is missing. Added additional error ot handle this. On UTXO discovery, they're ignored, and balance can be returned, but without unblinded UTXOs.
6584157 - Fixed inconsistent final sequence injection. After the update, we're insertingENABLE_LOCKTIME_NO_RBFwhen locktime is non-zero and non-final, or zero. In the previous case, we could create a transaction with locktime and forget to insert the sequence.d0ed063 - Fixed issue with a possible tricky hash collision on local imports build. External paths in folders outside the project are banned. Explicit Imports using a file system path to a library must be in the same folder to reduce faulty dependency injection. Tags and branches are now cloned explicitly (we can easily clone a branch instead of a tag when they have the same name).
Commits can be easily cherry-picked.
PS
Regarding other issues:
RequiredSignature::Noneshould be mulled over beforehand.