Repository navigation
Remove the daemon module and hal-simplicity-daemon binary - #52
Open
stringhandler wants to merge 1 commit into
Open
stringhandler wants to merge 1 commit into
stringhandler wants to merge 1 commit into
Conversation
The JSON-RPC daemon was an optional, off-by-default feature that was not built or tested in CI and is not documented. It exposes key generation and program execution over unauthenticated plain HTTP with no request size or resource limits, so it is not suitable for production use and keeps attracting security reports. All of its functionality is a thin wrapper around the `actions` module, which remains available to library users. This removes the `daemon` feature, the `hal_simplicity::daemon` module, the `hal-simplicity-daemon` binary, and the daemon-only dependencies (chrono, hyper, hyper-util, http-body-util, tokio). Assisted-by: Claude Code (Claude Opus 5.5)
Contributor
|
Yeah, this seems reasonable enough. The goal was to provide an easy way for other languages to use the tool. But they can shell out to the cli tool for example. |
Contributor
|
39562f1 needs rebase |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing the daemon due to the amount of AI reports against it. It's not used anywhere AFAIK.
The JSON-RPC daemon was an optional, off-by-default feature that was not built or tested in CI and is not documented. It exposes key generation and program execution over unauthenticated plain HTTP with no request size or resource limits, so it is not suitable for production use and keeps attracting security reports. All of its functionality is a thin wrapper around the
actionsmodule, which remains available to library users.This removes the
daemonfeature, thehal_simplicity::daemonmodule, thehal-simplicity-daemonbinary, and the daemon-only dependencies (chrono, hyper, hyper-util, http-body-util, tokio).Assisted-by: Claude Code (Claude Opus 5.5)