Repository navigation
Refactor: AST Scope - #450
Merged
LesterEvSe merged 4 commits intoOct 23, 2026
Merged
Conversation
LesterEvSe
force-pushed
the
refactor/ast-scope
branch
from
October 22, 2026 14:40
f124759 to
ea996f9
Compare
LesterEvSe
force-pushed
the
refactor/ast-scope
branch
from
October 22, 2026 15:20
ea996f9 to
cafba5e
Compare
Collaborator
Author
|
Polished some code after that |
Collaborator
Author
|
Kyrylo previously suggested some minor improvements to the AST, such as replacing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scopehas grown too large and handles many unrelated responsibilities at once:This PR splits it into several smaller structs and replaces the
pub(super)fields with getters.Scopeis now much simpler:Checklist
fixtures/kitchen_sink.simf(see its header).