Repository navigation
ci: pin workflow node versions to 22.23.4 - #294
Draft
ralph-bitgo[bot] wants to merge 1 commit into
Draft
ralph-bitgo[bot] wants to merge 1 commit into
ralph-bitgo[bot] wants to merge 1 commit into
Conversation
Replace the floating node-version selectors (22 and '22') in audit-api-spec.yaml and release-to-ghcr.yaml with '22.23.4' so the audit and release jobs run the same Node runtime as the pinned build images, .nvmrc, and the remaining workflows. Why: WCN-3707 requires every Node selector in this service's own files to be aligned to 22.23.4, the supported floor for the 22 line containing the October 2026 security fixes. Floating selectors can drift ahead of the pinned image runtime; pinning keeps CI deterministic and consistent with the repo's supply-chain pinning pattern. Ticket: WCN-3707 Session-Id: bae37fd2-808b-4ee3-88ca-fc6327ca4ca2 Task-Id: 160382e8-626a-4317-a37e-000b0883a1ad Requested-By: Andy Fischer <andyfischer@bitgo.com>
ralph-bitgo
Bot
force-pushed
the
wcn-3707-node-22.23.4
branch
from
October 21, 2026 23:09
3741073 to
fa12b6d
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
22.23.4:.github/workflows/audit-api-spec.yaml(x2) and.github/workflows/release-to-ghcr.yaml(x2) —node-version: 22/'22'→'22.23.4'.Dockerfileandintegration-tests.Dockerfile,ENV NODE_VERSION,.nvmrc, README floor,pull_request.yamlandbuild-and-test.yamlselectors) already landed onmastervia fix(docker): upgrade node runtime to 22.23.4 #291 and docs(docker): update README node prerequisite to 22.23.4 #292. This PR covers only the residual CI alignment from ticket step 6; scope was reduced after those merges landed mid-session.Why
22selectors resolve to whatever latest 22.x the runner serves and can drift ahead of the pinned image/.nvmrcruntime; pinning keeps audit and release jobs on the exact validated runtime and consistent with the repo's supply-chain pinning pattern.WCN-3707 runtime verification (state now on master)
docker pull --platform linux/amd64 node:22.23.4-alpine→Digest: sha256:ce8d97f7cfc7c5386421eb932df20a29df99b1a7f469f6157d5c9956702ffadc;docker inspect --format='{{index .RepoDigests 0}}'→node@sha256:ce8d97f7cfc7c5386421eb932df20a29df99b1a7f469f6157d5c9956702ffadc. This matches the digest pinned inDockerfile(builder + production) andintegration-tests.Dockerfile(builder + runner) on master.docker run --rm node:22.23.4-alpine node -v→v22.23.4..nvmrccontains22.23.4.ENV NODE_VERSION=22.23.4in the builder stage.grep -n "node:" Dockerfile integration-tests.Dockerfileshows onlynode:22.23.4-alpinewith that digest; no stale22.14.0/22.1.0references remain in the service's files.Deployment usage of the recipe
.github/workflows/release-to-ghcr.yamlbuildsDockerfileand pushesghcr.io/bitgo/advanced-wallets:<version>and:latest;.github/workflows/pull_request.yamlgrantspackages: readannotated "required for ArgoCD deploy", i.e. ArgoCD deploys the GHCR image built from this recipe.docker-compose*.ymlare local dev only). Rollout child WCN-3713 records the actually deployed Node version and rollback criteria.Test plan
node-versionselectors in.github/workflowsall resolve to22.23.4(or theinputs.node-versiondefault, already22.23.4)Ticket: WCN-3707